Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ to new users.
Volunteers are always welcome!

## Documentation
- [Visual Language](https://solidos.github.io/solid-panes/Documentation/VisualLanguage.html)
- [Conventions](./Documentation/conventions.md)
- [Visual Language](https://solidos.github.io/solid-panes/docs/VisualLanguage.html)
- [Conventions](./docs/conventions.md)
- [Navigation design](./docs/navigation-design.md)

### Profile heading

Expand All @@ -65,11 +66,11 @@ shows the resource as usual with the navbar visible and nothing selected; choosi
in the navbar replaces that view with the whole storage, with the container or resource
from the URL opened inside it. Any other pane on a page inside someone else's pod
(for example their container) shows the compact heading of that pod's owner; it is
hidden inside the viewer's own pod and for account-menu views. Pressing Enter on the current URL, or using the browser's
back and forward buttons, re-renders the page without a reload: Enter shows the
URL's own profile (and selects it in the navbar), while back and forward restore
what each history entry displayed, including account-menu entries that keep a
different profile in the URL. Solid-panes locally presents the heading data and checks
hidden inside the viewer's own pod and for account-menu views. Pressing Enter on the current URL,
or using the browser's back and forward buttons, re-renders the page without a reload, and
like a reload shows what the URL is: the profile on a WebID (selected in the navbar), otherwise
the container or resource itself, whatever the history entry last displayed through the navbar
or the account menu. Solid-panes locally presents the heading data and checks
viewer edit access; the component owns the edit interaction and opens the local
heading editor. The page controller refreshes the heading after a successful save.
After a successful save the component also dispatches a bubbling, composed
Expand Down
318 changes: 318 additions & 0 deletions docs/navigation-design.md

Large diffs are not rendered by default.

134 changes: 67 additions & 67 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/components/file-explorer-header/FileExplorerProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import styles from './FileExplorerProvider.styles.css'
import personIcon from '../../icons/person.svg'
import friendsIcon from '../../icons/friends.svg'
import '~icons/lucide/share-2'
import { explorerHeaderForPane } from '../../navigation/chrome'

const PERSON_ICON = personIcon
const FRIENDS_ICON = friendsIcon
const PERSON_PANE_NAMES = ['profile', 'social']

function createFileExplorerContextValue (value: {
store: LiveStore | undefined
Expand Down Expand Up @@ -242,7 +242,7 @@ export default class FileExplorerProvider extends WebComponent {
const store = this.context?.session.store as LiveStore
const subject = store.sym(this.subjectUri as string)
// Profile and friends panes present a person, not the resource they are opened on.
const showHeader = this.showHeader && !PERSON_PANE_NAMES.includes(this.pane?.name ?? '')
const showHeader = explorerHeaderForPane(this.showHeader, this.pane?.name)
return html`
<div class="file-explorer-provider">
${showHeader
Expand Down
1 change: 0 additions & 1 deletion src/components/navbar/Navbar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export interface NavbarMenuItem {
selected?: boolean
paneName?: string
paneUri?: string
profileSubjectUri?: string
onSelected?(): void | Promise<void>
}

Expand Down
2 changes: 2 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
} from 'pane-registry'
import { createContext } from './outline/context'
import { initMainPage, refreshUI } from './mainPage'
import { isHandlingBrowserNavigation } from './navigation/browserEvents'

function getOutliner (dom, environment?: RenderEnvironment): OutlineManager {
if (!dom.outlineManager) {
Expand Down Expand Up @@ -69,6 +70,7 @@ export {
versionInfo,
initMainPage,
refreshUI,
isHandlingBrowserNavigation,
list, // from paneRegistry
paneForIcon, // from paneRegistry
paneForPredicate, // from paneRegistry
Expand Down
Loading
Loading