Repository navigation
Remove unused mutex_m runtime dependency - #235
Merged
Merged
Conversation
Nothing in lib/ requires mutex_m or uses Mutex_m; the gem only uses plain Mutex. The dependency was added alongside base64 and bigdecimal when Ruby 3.4 stopped shipping them as default gems, to cover older Active Support releases that loaded mutex_m themselves. app_profiler now requires activesupport >= 7.2, which no longer uses mutex_m. Co-authored-by: Gira Chawda <gira.chawda@shopify.com>
hmcguire-shopify
approved these changes
Oct 27, 2026
paracycle
approved these changes
Oct 27, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove the unused
mutex_mdependency from app_profiler.What
app_profiler no longer declares
mutex_mas a runtime dependency because the gem does not useMutex_mor requiremutex_manywhere. The lockfile and changelog are updated to match.Tophat
CI passing.