Repository navigation
fix(platform): port native validation and runtime recovery fixes - #4626
Merged
Merged
Conversation
Ports the net change of #4584, about 30 commits from another session that never landed, onto the legacy-removal integration branch: - Windows: rules_rust patch separating link metadata outputs, explicit daemon transport ownership, supervised ChatGPT-extension shutdown, and the daemon authority location. - Sessions: transcript progress uses the canonical native rewrite witness; generations chain across transcript replacements. - Hooks: Codex PostCompact joins the per-session projection owner; receipt handoff and recovery tests are deterministic. - Code index: changed incumbents are recaptured through bounded supersession; retained rebuilds return to authoritative reconciliation. - MCP: a retired response is recovered only for a read-only tool; each new connection gets a new application request identity, so effectful calls are never replayed. - Fixtures: TLS certificates within native validity limits (fixes the remote_cli_test HTTPS cases), socket paths within Unix limits, canonical fixture roots. Conflicts resolved for the legacy removal: - the pre-lease task-lock process test stays deleted; - the serve-client `data.code` error fallback is not restored; - re-exports of the deleted MCP test helpers stay dropped; - the Windows service helpers use tracedecay_private_fs::windows; - the portable broker returns Ok(None) on the build-match refusal. The HEAD-resolution and hook-scope changes were already on master as 72772d1. The ChatGPT-extension embed was regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
… fix/platform-native-validation
… fix/platform-native-validation
ScriptedAlchemy
changed the base branch from
integration/legacy-removal
to
master
October 30, 2026 06:25
ScriptedAlchemy
enabled auto-merge (squash)
October 30, 2026 06:25
Windows dynamic execution ran an unsandboxed local rustc with lock-free output beside the remote branch. The losing copy wrote the execroot while the winning result landed, so Test Windows failed on every PR since #4629 with missing .rlib/.pdb outputs and output-digest mismatches. Restore remote-only Rustc on Windows with sequential local fallback for worker infrastructure errors. Linux and macOS keep sandboxed dynamic execution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the canonical toolchain patch and the Windows sealed-metadata fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master landed rules-rust-windows-action-outputs.patch (c9b0f57), which gives Windows link actions their own metadata output and drops stripped PDBs. It replaces this branch's rustc.bzl hunks from rules-rust-windows-metadata-outputs.patch, so that patch is cut down to the hunk master lacks, Windows Clippy's own metadata output, as rules-rust-windows-clippy-metadata.patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the short SDK fixture homes from #4644 instead of the older /tmp workaround. This fixture matches the five passing Mac daemon journeys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 31, 2026
#4626 narrowed the test-only RMCP re-exports to cfg(all(test, unix)). Keep that gate and this branch's removal of the root RmcpInitializeResponseDecorator alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 31, 2026
#4626 already stopped discarding the compaction error: it logs the error and keeps the fixed "daemon compaction failed" reason. Keep that over this branch's reason with the error text interpolated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 31, 2026
#4626 platform-gated the daemon logging imports in branch_add.rs and pr_autotrack.rs. Keep those gates and this branch's canonical_or_original import, which the ungated callers on every platform still use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#4584 carried about 30 fix commits from another session on a Renovate branch. It conflicted with master and never landed, because the earlier combined PR #4589 didn't include it. This PR ports its net change onto current code. It is based on
integration/legacy-removal(#4623) so the legacy-removal conflicts are resolved once. Once #4623 merges, it will be retargeted to master.What it brings
rules_rustpatch so link actions don't overwrite sealed metadata outputs.core_cli_suiteremote_cli_testHTTPS cases that failed on master.Conflict resolution
Where #4584 conflicted with the legacy removal, the removal won:
data.codeerror shape is not restored.&error) but calltracedecay_private_fs::windows, their new location.Ok(None)inside fix(platform): repair native validation and runtime recovery - abandoned #4584's refactored authentication helper.The hook HEAD-resolution and hook-scope changes were already on master as
72772d128b, so they are skipped. The ChatGPT-extension embed was regenerated.Verification
bazel build --config=clippy //crates/...: clean.bazel test //...: 173/173 pass, includingcore_cli_suite.tsc --noEmitclean, andcheck:embeddedreports the embed is current.gen_buildsproduced no changes. rustfmt is clean on every changed Rust file.Supersedes #4584.
🤖 Generated with Claude Code