Repository navigation
Conversation
- 상세 마감일 수정·클래스 정보 수정을 수정 화면으로 연결하고 이름·마감일을 PATCH 1회로 저장 - 멤버 화면은 명단 수, 상세·내 클래스 카드는 서버 memberCount 로 표시 - 종료 배지 스타일 분리, 마감 뒤 배틀 참여 시 토스트 표시 - 상세·공유·수정 화면이 클래스 배틀 조회로 카테고리·입장 표시, 관리 시트 공유 행을 공유 화면으로 연결 - 운영자·멤버 공용 결과 화면 추가 (AI 인사이트, 입장분포 도넛, 요약·내 리포트 탭) - AI 토론 실패 문구를 Android 토스트와 맞춤 - Android 대조 기록 docs/class-android-ios-parity-20261120.md 추가 Claude-Session: https://claude.ai/code/session_012p64qXwb8pRZk3XarivXcj
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3cce2c70b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| room.role == .owner | ||
| else { return .none } | ||
| return openDeadlineEditor(state: &state, room: room) | ||
| state.routes.push(.classEdit(.init(room: detail.room))) |
There was a problem hiding this comment.
Keep the deadline picker alive on the new edit route
For an owner editing a class with a deadline, this replaces the working deadline editor with ClassEdit, but that screen cannot present its deadline picker: .classEdit(.delegate(.editDeadline)) sets state.deadlineSelection, then the coordinator's post-reduction cleanup immediately clears it because it only accepts a matching .setting route (lines 144–150). Consequently, tapping the deadline field does nothing, and the detail screen's previously available deadline-extension flow is broken. Update that cleanup to also retain a selection belonging to the current .classEdit instance.
Useful? React with 👍 / 👎.
| case report = "내 리포트" | ||
| } | ||
|
|
||
| public struct Loaded: Equatable, Sendable { |
There was a problem hiding this comment.
Extract the result presentation model from the reducer
The new Loaded presentation model is nested inside the reducer and is referenced directly by the view as ClassResultFeature.Loaded. Root AGENTS.md explicitly requires presentation models to be top-level types in the same module's Model/ directory and limits Feature files to reducer components. Move this payload to its own model file and update the state, actions, and view signatures so the new result screen follows that required separation.
AGENTS.md reference: AGENTS.md:L475-L477
Useful? React with 👍 / 👎.
요약
2차 iOS QA 시트의 클래스 실패·보류 항목을 Picke-android(
6fbdf86) 동작과 같게 맞췄습니다. 항목별 Android 근거(file:line)는docs/class-android-ios-parity-20261120.md에 있습니다.변경
PATCH /classes/{id}1회로 저장memberCount(#84의activeMemberCount표기를 Android 기준으로 되돌림)/classes/{id}/battle로 카테고리·입장·소요 시간 표시, 관리 시트 공유 행 → 공유 화면ClassResult신규: 분홍 AI 인사이트 카드, 입장분포 도넛, 요약/내 리포트 탭(하나면 탭 바 숨김), 입장 변경 배지, 고정 제목 3개, "내가 남긴 의견 N개 보기"함께 바뀐 동작
변경 없음 (Android와 동일)
/members응답 그대로 표시 → 서버 확인 필요확인
Picke-Stage빌드 성공testClassRecommendLayout실패. develop(bf32d772)에서도 같은 항목이 실패해 기존 문제로 판단. 마지막 재실행은sentry-cocoa9.34.0 소스 컴파일 오류(SentrySDK.swift:260)로 빌드 단계에서 중단https://claude.ai/code/session_012p64qXwb8pRZk3XarivXcj