Repository navigation
서버 v3.0.4 클래스 응답 변경 반영 - #84
Merged
Merged
Conversation
- 멤버 수: activeMemberCount 를 받아 "멤버 N명" 표시에 사용 (memberCount 는 사용 좌석 수로 유지) - AI 토론 철학자 이미지: 서버 philosopher.imageUrl 우선 사용 (이름·얼굴 불일치 수정) - 커스텀 배틀 태그: 클래스 배틀 상세 battle.categoryTags 를 투표 화면 카테고리로 표시 - 이용권 코드: PKE+6자리(9자) 입력 제한, 예시 문구 변경, TICKET_429_LOCKED 5회 잠금 안내 - 참여 오류: CLASS_409_TICKET_ENDED 를 마감과 다른 문구로 구분 Claude-Session: https://claude.ai/code/session_012p64qYTmqHhkJDFnd2C6KB
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| await store.send(.binding(.set(\.code, "pke-05d2e1"))) { | ||
| $0.code = "pke-05d2e1" | ||
| } | ||
| #expect(store.state.normalizedCode == "PKE-05D2E1") |
Contributor
There was a problem hiding this comment.
🟠 [P2] Major
normalizedCode는 state.code에서 하이픈을 제거하고 대문자로 변환한 값입니다. 따라서 "pke-05d2e1"이 state.code로 설정되었을 때, normalizedCode는 "PKE05D2E1"이 되어야 합니다. 현재 테스트는 "PKE-05D2E1"을 기대하고 있어 잘못된 기댓값을 가지고 있습니다.
수정 방향: normalizedCode의 기댓값을 "PKE05D2E1"으로 변경해야 합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
서버 v3.0.4 클래스 API 변경(
docs/api-specs/class-api.md)을 앱에 반영했습니다.변경
activeMemberCount로 "멤버 N명" 표시(내 클래스 카드·상세·멤버 목록).memberCount는 사용 좌석 수로 유지philosopher.imageUrl로 표시 (칸트 이름·얼굴 불일치 수정)battle.categoryTags를 투표 화면#카테고리로 표시PKE+6자리(9자) 입력 제한, 예시 "예: PKE05D2E1",TICKET_429_LOCKED잠금 안내CLASS_409_TICKET_ENDED를 마감(CLASS_409_CLOSED)과 다른 문구로 구분변경 없음
운영자 && 내가 아닌 멤버조건확인
https://claude.ai/code/session_012p64qYTmqHhkJDFnd2C6KB