Repository navigation
Sentry 바이너리 서명 폐기로 소스 빌드(SentrySPM)로 전환 - #83
Merged
Merged
Conversation
- Sentry 가 11/13 서명 인증서를 폐기해 9.34.0 이하 xcframework 가 아카이브에서 거부됨 (sentry-cocoa #9633) - Sentry·SentrySwiftUI 바이너리 대신 SentrySPM 제품 사용, sentry-cocoa 9.34.0 으로 고정 - PickeAnalytics import 를 SentrySwift 로 변경 Claude-Session: https://claude.ai/code/session_012p64qYTmqHhkJDFnd2C6KB
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Sentry 바이너리 xcframework 서명 폐기로 인한 소스 빌드(SentrySPM) 전환 PR을 검토했습니다. 변경된 [LINE N] 코드들은 Sentry 라이브러리 교체 및 관련 import 문 수정에 대한 의도를 명확하게 반영하고 있습니다. 제공된 PR 설명과 변경사항이 일치하며, 아키텍처 원칙이나 예상되는 런타임 문제가 관찰되지 않습니다. PR 설명에 언급된 대로 fastlane QA 아카이브 및 dSYM 업로드 성공이 확인되었다면 이 변경은 적절합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
Sentry 바이너리 xcframework 서명 인증서가 폐기돼(sentry-cocoa #9633, CSSMERR_TP_CERT_REVOKED) 아카이브가 실패해서, 소스 빌드 제품(SentrySPM)으로 바꿨습니다.
변경
Tuist/Package.resolved)Tuist/Package.swift:Sentry,SentrySwiftUIproductTypes 제거TargetDependency.SPM.sentry를SentrySPM으로 교체,sentrySwiftUI삭제import Sentry/SentrySwiftUI→import SentrySwift확인
fastlane QA아카이브·ipa 내보내기·dSYM 업로드 성공https://claude.ai/code/session_012p64qYTmqHhkJDFnd2C6KB