Repository navigation
Fix #399 - #401
Merged
antoineatstariongroup merged 1 commit intoOct 29, 2026
Merged
Fix #399#401
Conversation
4 of 5 tasks
|
samatstariongroup
approved these changes
Oct 29, 2026
samatstariongroup
left a comment
samatstariongroup
left a comment
Member
There was a problem hiding this comment.
looks good to me, minor comment, why add a new line?
| public void Serialize(IEnumerable<IIdentified> dataItems, SerializationModeKind serializationModeKind, bool includeDerivedProperties, Stream stream, JsonWriterOptions jsonWriterOptions) | ||
| public void Serialize(IEnumerable<IIdentified> dataItems, SerializationModeKind serializationModeKind, bool includeDerivedProperties, Stream stream, | ||
| JsonWriterOptions jsonWriterOptions) | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
Just to be compliant with wrapping rules that are set on the editorconfig
antoineatstariongroup
deleted the
399-bug-serializerserializeresponseasync-writes-synchronously-to-the-target-stream
branch
October 29, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #399
Async serialization never calls any non-async flush