Repository navigation
feat(web): upgrade to React 19 - #23
Merged
Merged
Conversation
useRef now requires an initial value, so the draft saver ref is created with undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
react,react-dom,@types/reactand@types/react-domto 19.3 together. Dependabot proposed these separately (#11, #19), which can't work: react-dom 19 requires react 19.Breaking changes handled
useRefrequires an argument in React 19's types:useRef<DraftSaver | undefined>(undefined)inuseWorkspace.ReactDOM.render,defaultProps,propTypes, string refs or legacy context). The entry point already usescreateRoot.Libraries checked
react-router-dom7,@tanstack/react-query5, and@monaco-editor/react4.7 all support React 19.Verification
npm run typecheck,npm test(17 passed),npm run lint,npm run build.The toolchain upgrade (TypeScript, Vite, Vitest, ESLint) follows in a separate PR stacked on this one.