Repository navigation
fix(audit-log): show role names next to mentions in member role updates - #511
Open
Mathieu133 wants to merge 1 commit into
Open
Mathieu133 wants to merge 1 commit into
Mathieu133 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dual-server mode, the "Member Roles Updated" audit log is posted on the other
guild, where the role doesn't exist, so the mention renders as "@unknown-role".
This adds the role name next to the mention, e.g. <@&ID> (
Role name),using the
namefield already provided by serenity'sAffectedRole.Same format as the one already used in
formatters/role.rs.