Repository navigation
fix(react): allow anonymous users to fetch starred and pinned messages - #1390
Open
ydvvdinesh wants to merge 1 commit into
Open
ydvvdinesh wants to merge 1 commit into
ydvvdinesh wants to merge 1 commit into
Conversation
- Remove redundant outer if (isUserAuthenticated) guard in useFetchChatData.js so getStarredMessages and getPinnedMessages properly honor anonymousMode. - Configure packages/react/babel.config.js to allow ES module compilation during Jest test execution. - Add unit tests verifying message fetching in unauthenticated with anonymousMode, unauthenticated without anonymousMode, and authenticated states. Signed-off-by: Dinesh Yadav <bawwadinesh@gmail.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(react): allow anonymous users to fetch starred and pinned messages
Acceptance Criteria fulfillment
if (isUserAuthenticated)guard inuseFetchChatData.jsforgetStarredMessagesandgetPinnedMessages.anonymousModeto fetch starred and pinned messages when unauthenticated.packages/react/babel.config.jsto enable module transformation during test runs.packages/react/src/hooks/useFetchChatDataMessages.test.jscovering unauthenticated + anonymousMode, unauthenticated + standard, and authenticated states.Description
In
useFetchChatData.js, bothgetStarredMessagesandgetPinnedMessagescontained an outerif (isUserAuthenticated)check wrapping an inner guard:if (isUserAuthenticated) {
try {
if (!isUserAuthenticated && !anonymousMode) {
return;
}
const { messages } = await RCInstance.getStarredMessages();
setStarredMessages(messages);
} catch (e) { ... }
}