Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new source-tree traversal lacks regression coverage for nested interfaces, file and directory symlinks, cycle termination, and lexical-path preservation through sibling aliases.
1 open issue
What changed in this PR
Replaces walk with built-in asynchronous filesystem traversal for ROS interface discovery, sharing collection logic between source trees and ament-index installations.
Changes:
- Uses an async generator that preserves symbolic-link paths and prevents ancestor-directory cycles.
- Reuses interface processing and awaits it so processing failures propagate.
- Removes the
walkdependency.
| File | Description |
|---|---|
rosidl_gen/packages.cjs |
Adds filesystem traversal and shares awaited interface collection logic. |
package.json |
Removes the walk dependency. |
Review effort: Balanced
| return pkgMap; | ||
| } | ||
|
|
||
| async function* findFilesInDirectory(dir, ancestors = new Set()) { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

walkdependency and usefs.promiseswith an async generator.Fix: #1673