Repository navigation
chore(ci): publish from the release run instead of a release-branch push - #254
Merged
Merged
Conversation
The publish job now lives in create-release.yml, after the tag and under the production environment, so the approval prompt lands on the run being watched. A failed publish is retried with "Re-run failed jobs" on that run; the version and tag are already cut. PyPI's trusted publisher must name create-release.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish.ymlis gone. Its job now runs insidecreate-release.ymlaftercreate-tag, under theproductionenvironment, so the required-reviewer prompt lands on the run just dispatched instead of on a second workflow./publish,/create-pr,/staged-reviewand/release-notescommand docs describe the new flow.Before the next release
PyPI's trusted publisher for
robosystems-clientmust listcreate-release.ymlwith environmentproduction. PyPI does not accept a reusable workflow as a trusted publisher, which is why the job is embedded rather than called. Thepublish.ymlentry can be removed once a release has gone through.🤖 Generated with Claude Code