Repository navigation
feat(ledger): a journal entry line's cash flow row, and the in-place re-tag - #253
Merged
Merged
Conversation
…re-tag Regenerated against robosystems #1812. UpdateJournalEntryRequest gains line_flows; the line input and response carry flow_qname; the journal list selects flowQname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated against robosystems #1812 (a journal entry's lines carry a cash flow row, re-taggable in place). Additive, generated tier: a client minor. The
LedgerClientfacades need no change beyond their docs:create_journal_entrytakesflow_qnameon a line dict, andupdate_journal_entrytakesline_flowsthroughUpdateJournalEntryRequest.from_dict.UpdateJournalEntryRequestgainsline_flows(JournalEntryLineFlow:line_id,flow_qname), the in-place re-tag of a posted entry's lines;JournalEntryLineItemInputandJournalEntryLineItemResponsegainflow_qname; the update operation's description follows the server's.ListLedgerJournalEntriesselectsflowQnameon each line;schema.graphqlrefreshed (LedgerLineItem.flowQname).api/andmodels/wholesale; the diff beyond the new fields is comment drift.Waits on the server release carrying robosystems #1812 (the next after v1.16.19).
flowQnameis a new GraphQL selection, solist_journal_entriesfails validation against a server without it. The TypeScript client's twin is robosystems-typescript-client's PR of the same name.Test plan
just generate-sdk,just refresh-schema,just generate-graphqlfrom the local stack running #1812just test(688 passed; new:line_flowsreaches the request model and the response carries each line's flow)just lint,just typecheck🤖 Generated with Claude Code