[MantisClone]

Problem

SDK checks exposed two separate problems: signature recovery can silently fall back to slow JavaScript, and request confirmation can be missed or overwritten by an older refresh. Some tests also compare requests before confirmation or rely on exact wall-clock timing.

This is the non-security prerequisite for #1776, found while validating REQ-716.

Proposed Solution

• Resolve node-gyp-build to 4.8.4 throughout the workspace and check native secp256k1 loading immediately after CI installation.
• Retain creation confirmation/error results for late or repeated callers. Process refreshes in order, allowing retries after a failed read.
• Cover those confirmation races, wait before comparing encrypted requests, and compare public request data. Check retry delays with fake timers.

Design Rationale

The lockfile previously selected loader 4.8.4 for installation and 4.6.0 for runtime loading. In an isolated reproduction using the CI image, installation succeeded but runtime loading missed the packaged native binary and selected the JavaScript fallback. Aligning the loaders restores native loading; the CI check makes a recurrence visible.

Retaining confirmation results handles late callers. Serializing refreshes prevents an older pending read from overwriting confirmed state. Longer timeouts would not fix either race.

Considerations

The Node version update stays in #1776, stacked above this PR. Test timeouts, worker counts, retry behavior and Lit Protocol code are unchanged. The loader resolution applies to this workspace's installation; it does not force downstream consumers' dependency resolutions.

Validation

• An isolated frozen-lockfile install resolves loader 4.8.4 without changing the lockfile. Lifecycle scripts were disabled for this dependency check; the native installer was tested separately in the CI image.
• In cimg/node:22.23.4, installation and native loading pass with no compiled addon present. Before the fix, the equivalent loader mismatch selected the JavaScript fallback.
• With packaged prebuilds forced on, the three affected Request Client suites pass 103 tests on Node 22.23.4. Two localhost-dependent cases are excluded; one case is already skipped. All five cases from the latest CI failure are included and pass. Retry passes 9 tests.
• On the prerequisite's existing Node 22.14.0 version, 31 selected declarative/confirmation tests pass.
• TypeScript, formatting and YAML parsing pass. Production-file ESLint has no errors and 27 existing warnings. Fresh hosted checks remain pending.

UAT

After publishing the candidate SDK, create a permitted staging request. Wait for confirmation, call waitForConfirmation() again after it resolves, and confirm both calls return the confirmed request. Read the same request through a fresh client and confirm its ID, state and content match. Confirm the native-loading check and existing CircleCI suites pass.

[MantisClone]

• fix: use patched Node 22 for SDK builds #1776
• fix: load native signatures and preserve request confirmation #1777 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR aligns node-gyp-build, checks native signature loading in CI, and preserves request creation results for late or repeated callers.

• Request confirmation keeps its refreshed result for every caller.
• CircleCI checks native signature loading with the workspace's 4.8.4 loader.
• Retry delay tests use fake time instead of the wall clock.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Creation confirmed] --> B[Queue refresh]
  C[Earlier refresh] --> D[Earlier refresh settles]
  D --> B
  B --> E[Read current request data]
  E --> F[Emit confirmed]
  F --> G[Retain confirmation result]
  G --> H[Late and repeated waits receive result]

Loading

_{Reviews (1) · Last reviewed commit: "fix: load native signatures and preserve..." · Reviewed by Greptile}

[MantisClone]

Merge activity

• Oct 30, 9:14 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Oct 30, 9:14 PM UTC: @MantisClone merged this pull request with Graphite.