Repository navigation
fix: run Request Node on patched Node 22 - #31
Merged
Merged
Conversation
MantisClone
requested review from
LeoSlrRf,
aimen74,
alexandre-abrioux-rf,
bassgeta and
rodrigopavezi
October 27, 2026 21:08
alexandre-abrioux-rf
approved these changes
Oct 27, 2026
[Medium impact] The reviewed changes appear safe to merge; no actionable issues were found. SummaryUpdates Request Node’s build and runtime base to digest-pinned Node 22.23.4 on Alpine 3.23.
Reviews (1) · Last reviewed commit: "fix: run Request Node on patched Node 22" · Reviewed by Greptile |
rodrigopavezi
approved these changes
Oct 27, 2026
MantisClone
added a commit
to RequestNetwork/requestNetwork
that referenced
this pull request
Oct 30, 2026
# Problem The SDK still selects Node 22.14.0 locally and 22.14 in CircleCI, before the October security fixes. Tracked in [REQ-716](https://linear.app/requestnetwork/issue/REQ-716). # Proposed Solution Use Node 22.23.4 in `.nvmrc` and CircleCI. This PR changes only those two version selections. # Design Rationale The update stays within Node 22, which the SDK already supports through [PR 1595](#1595). Native-loader, confirmation and test corrections are separated into prerequisite [#1777](#1777). # Considerations Merge #1777 first. The [docker-images companion PR](RequestNetwork/docker-images#31) updates the gateway runtime separately; this PR alone does not patch a running gateway. The planned normal release targets client SDK 0.66.0 and gateway 0.52.0. Installing the SDK does not upgrade a consuming application's Node runtime. Final package/image checks and staging request submission/readback remain required before production. # Validation With the prerequisite fixes, the three affected Request Client suites pass 103 tests on Node 22.23.4 using packaged native binaries. Two localhost-dependent cases are excluded; one is already skipped. Retry passes 9 tests. Native installation/loading also passes in `cimg/node:22.23.4` without a compiled addon. YAML parsing passes. Fresh hosted checks remain pending. # UAT Confirm the existing CircleCI build and test jobs pass on Node 22.23.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Request Node Docker image still uses end-of-life Node 18.19.0. The tested 0.38.0 image also accepts the compromised eMudhra certificate chains. This addresses the runtime upgrade requested in private issue 236 and the current security update in REQ-716.
Proposed Solution
Use Node 22.23.4 on Alpine 3.23 for the gateway build and runtime. Pin the base image by its SHA-256 digest and record the source repository and commit in the image labels.
Design Rationale
Node 22 provides the required security fixes and is already used by the SDK. The gateway image is built here, so changing the SDK toolchain alone would not update its deployed runtime. The companion SDK PR updates its build toolchain. Preserve the existing release inputs and version tags.
Considerations
Merge this change before the normal SDK release, targeting client SDK 0.66.0 and gateway 0.52.0. SDK release-tools then builds the image using the exact released gateway package. Verify that build succeeds and validate its published digest in staging before production. Retain the previous deployed image/configuration for rollback. No ongoing 0.38.x maintenance line is planned.
The gateway upgrade includes application and dependency changes, including topic-query pagination and Lit authorization behavior. Validate existing clients against those changes. The local build reports Lit deprecation warnings; test that integration if the gateway uses it. PostgreSQL, IPFS, Graph application and host-package updates are outside this PR.
Validation
CERT_REVOKEDand connects successfully to both legitimate HTTPS test sites.UAT
If checks fail, restore the previous image and configuration. Keep stored data intact. Check whether pending submissions completed before retrying them.