Repository navigation
Limit scratch asset upload size - #1051
Merged
Merged
Conversation
Test coverage94.11% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-limit-scra-eteos8
October 8, 2026 15:20
Inactive
mwtrew
marked this pull request as ready for review
October 13, 2026 13:06
zetter-rpf
approved these changes
Oct 13, 2026
zetter-rpf
left a comment
zetter-rpf
left a comment
Contributor
There was a problem hiding this comment.
Nice one,
I might have mentioned this before, but we get value from using environment variables if they:
- Protect secrets that we don't want in our codebase
- Make it easy to vary a value per environment (I'm not counting tests as a class attribute would be just as easy to set/stub as an Env var).
Here I don't think there's much benefit and it makes it harder to set up because they are still in source control, just in a different repo (in terraform).
Contributor
Author
Fair point, I think I'll leave it for now but happy to change it later if it causes any trouble 👍 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
SCRATCH_ASSET_MAX_SIZE_MBenv var.Steps to perform after deploying to production
Ensure https://github.com/RaspberryPiFoundation/terraform/pull/1497 is applied