Repository navigation
Adding GUI System Tests - #249
Open
MikeSullivan7 wants to merge 29 commits into
Open
MikeSullivan7 wants to merge 29 commits into
MikeSullivan7 wants to merge 29 commits into
Conversation
MikeSullivan7
marked this pull request as ready for review
August 21, 2026 17:02
MikeSullivan7
marked this pull request as draft
September 3, 2026 14:52
MikeSullivan7
marked this pull request as ready for review
September 3, 2026 15:43
StephenNneji
reviewed
Sep 4, 2026
StephenNneji
left a comment
StephenNneji
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this, please see comments
Also please update the unit testing section in contributing.md appropriately
MikeSullivan7
force-pushed
the
gui_system_tests
branch
6 times, most recently
from
September 15, 2026 13:17
e1e04c9 to
2dc1c80
Compare
StephenNneji
reviewed
Oct 7, 2026
StephenNneji
left a comment
StephenNneji
left a comment
Contributor
There was a problem hiding this comment.
Apologies for the long wait for review, still a few issues especially on Linux
| ("dream", 9.67234, 2000), | ||
| ] | ||
| ) | ||
| def test_run_slow(self, procedure_name, expected_chi, test_duration): |
Contributor
There was a problem hiding this comment.
I have a weird issue on my Linux machine where the slow test doesn't complete for some reason. It gets stuck on 99% for dream and finish is never printed for NS. Please can you investigate on a Vm or IDAaas
Collaborator
Author
There was a problem hiding this comment.
Ive got it working on my Linux VM, should be fine now
…m-tests and --run-unit-tests
… project in testing
… due to matlab runner not exiting properly
MikeSullivan7
force-pushed
the
gui_system_tests
branch
from
October 15, 2026 16:35
74fe79b to
b414c8c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new form of GUI System Test which creates an instance of RasCal2, performs a sequence of events (clicks, typing, etc) and tests the validity of the output. This is more useful than isolated unit tests as it tests theinteraction between different parts of the program and more closely resembles a realistic user workflow.
System tests inherit the
GuiSystemBaseclass, which handles thesetUpand tearDownof theself.main_window` instance, simplifying how the tests are written.Unit tests and System tests are differentiated in pytest. We can run only unit tests via:
pytest testsorpytest tests --run-unit-testsSystem tests are run by default but can be skipped via:
pytests tests --skip_system_testsTests which take too long are marked with a "skip" mark, to run these, use the flag:
pytests tests --run_slow_testsIf we want to include screenshot/eyes tests in the future, a flag can be created for them to differentiate screenshot tests from unit and system tests.