Skip to content

Use ifelse rather than ternary in scale! - #59

Merged
lkdvos merged 1 commit into
mainfrom
ksh/scal
Nov 6, 2026
Merged

lkdvos merged 1 commit into
mainfrom
ksh/scal

Conversation

@kshyatt

@kshyatt kshyatt commented Nov 6, 2026

Copy link
Copy Markdown
Member

Apparently the ternary operator is getting miscompiled on LLVM 15, this should fix things for TensorKit + AMDGPU + Julia 1.10

@kshyatt
kshyatt requested a review from lkdvos November 6, 2026 16:39
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/number.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos enabled auto-merge (squash) November 6, 2026 16:55
@lkdvos
lkdvos merged commit 9088ac2 into main Nov 6, 2026
10 checks passed
@lkdvos
lkdvos deleted the ksh/scal branch November 6, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants