Skip to content

Smaller cleanups - #12

Merged
borisdevos merged 26 commits into
mainfrom
bd/cleanup
Nov 3, 2026
Merged

borisdevos merged 26 commits into
mainfrom
bd/cleanup

Conversation

@borisdevos

@borisdevos borisdevos commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Besides some refactors, there were some problems with #2 which I fixed here, in particular the unit and dual calculations. I'm surprised they didn't error previously.

Summary of the important parts:

  • Iteration over the values is now row-major such that they are sorted. This was previously not the case, and not caught by the TKS testsuite because it only iterates to 10 sectors.
  • Tests are reproducible, and every unitarity check is done now.
  • Less allocations here and there
  • size isn't hardcoded and is replaced by an internal rank, so the first call to a sector goes through loading the Nsymbols first

Will have to revisit the readme after a package release

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/bimodulesector.jl 96.68% <100.00%> (+2.34%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borisdevos
borisdevos requested a review from lkdvos October 30, 2026 16:44
Comment thread src/bimodulesector.jl Resolved
Comment thread src/bimodulesector.jl Resolved
Comment thread Project.toml Resolved
@borisdevos
borisdevos merged commit 93a0cdc into main Nov 3, 2026
8 of 9 checks passed
@borisdevos
borisdevos deleted the bd/cleanup branch November 3, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants