Skip to content

chore: Remove test covered by summary fixture #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marius Merkle (MariusMerkleQC) merged 2 commits into from
Oct 27, 2026
Merged

chore: Remove test covered by summary fixture #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d481e
chore: Remove test covered by summary fixture
MariusMerkleQC Oct 26, 2026
91e2a66
Merge branch 'main' into rem_test
MariusMerkleQC Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions tests/summary/test_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,30 +40,6 @@ def test_summary_dunder_methods(
assert fn(summary) == summary.format(pretty=pretty)


@pytest.mark.parametrize("show_perfect_column_matches", [True, False])
@pytest.mark.parametrize("show_top_column_changes", [True, False])
def test_summary_all_columns_join_cols(
show_perfect_column_matches: bool,
show_top_column_changes: bool,
) -> None:
# Arrange
df = pl.DataFrame({"id": ["a", "b", "c"]})
comp = compare_frames(
df,
df.filter(pl.col("id") == "a"),
primary_key=["id"],
)

# Act
summary = comp.summary(
show_perfect_column_matches=show_perfect_column_matches,
top_k_column_changes=3 if show_top_column_changes else 0,
)

# Assert
assert "No common non-primary key columns to compare" in str(summary)


@pytest.mark.parametrize(
"fraction, decimals, expected",
[
Expand Down
Loading