Skip to content

sir_model: restore the 2025 reviewers' wording lost in #302 - #305

Merged
mmcky merged 1 commit into
mainfrom
recover/sir-model-review-wording
Oct 22, 2026
Merged

mmcky merged 1 commit into
mainfrom
recover/sir-model-review-wording

Conversation

@mmcky

@mmcky mmcky commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Part of #298. #302, the sync of QuantEcon/lecture-python.myst#1050, carried every English change into sir_model, but it also rewrote passages whose English did not change. The lecture carries a native review from 2025 (yuki, Humphrey Yang), and five of the twenty lines still attributed to that review were among the rewritten ones. This PR puts the reviewed text back where the English is unchanged and keeps every change the English made, in the manner of #304's var_dmd commit.

What changes

Where #302's text Restored Why
时间路径 跨状态的流动遵循路径… 状态之间的流动遵循路径… English unchanged
时间路径 我们主要关注以下几点:, then two reworded bullets 主要关注的是, then yuki's two bullets English unchanged
时间路径 用小写字母表示每种状态下人口的比例,动态方程为 使用小写字母表示处于各状态的人口比例,其动态方程为 the English changed only "lower case" to "lowercase"
时间路径 在这些方程中: 在这些方程中, English unchanged
时间路径 由于这些状态构成了一个划分,…处于 R 状态… 我们不需要单独建模处于 $R$ 状态的人口比例 $r$,因为这些状态构成一个分区。 English unchanged; R is math again
时间路径 具体而言,人口中“已移除”的比例为… 具体来说,“已移除”的人口比例为… English unchanged
时间路径 …即累计病例数(即所有曾经或正在感染的人)。 …即累计病例数(即所有已感染或曾经感染的人)。 English unchanged
参数 three reworded lines, one with 阿特克森 the three reviewed lines, with Atkeson English unchanged; the lecture writes Atkeson everywhere else
参数 (这个符号稍显混乱,…表示移除状态…) (这个符号表示有点令人困惑,…表示已移除状态…) English unchanged
SEIR 模型 易感($S$)、暴露($E$)、感染($I$)和移除($R$) 易感者($S$)、暴露者($E$)、感染者($I$)和移出者($R$) the intro's reviewed state names, with the English's new $S$, $E$, $I$, $R$
code set_xlabel('days') twice, ylabel='fraction of the population' four times '天数', '人口比例' 解除封锁 already used 人口比例, and the lecture loads the Chinese font

Where the restored text had ASCII quotes or parentheses, they are now full-width, as the zh-cn rules require.

What keeps #302's text

Checks

  • Structure: structural parity against lecture-python.myst main holds under the engine's guard at QuantEcon/action-translation f89f061. The 25 code cells match the source with string literals and comments masked; the only difference is this edition's font block. Both math blocks are byte-identical.
  • Restored text: every restored line is byte-identical to the text before 🌐 [translation-sync] [sir_model] update code and text #302, apart from full-width punctuation and the English's new math in the state list.
  • zh-cn rules (QuantEcon/project-translation#70): full-width punctuation, and a space between Chinese and an inline role or link, hold on every prose line. The text before 🌐 [translation-sync] [sir_model] update code and text #302 had 17 findings; main and this branch have none.
  • State: translate status still reads sir_model as ALIGNED. The state file is unchanged, because the source is.
  • Preview: the preview build executed sir_model in 2.85 s. Its log has no Executing notebook failed (The -W gate is blind in ci.yml, and a warning-only cache failure discards a completed execution #271), no traceback and no missing-glyph warning, and the HTML build succeeded.

The branch is a recover/ branch, so the rebase automation neither triggers on it nor rebases it, as with #300 and #301.

Not in this PR: the July forward resync (#151) had already dropped 26 of the reviewers' 47 lines in this lecture, before #302. Whether to restore those belongs with the audit of forward-written text (QuantEcon/action-translation#154), not with this repair.

🤖 Generated with Claude Code

#302, the sync of QuantEcon/lecture-python.myst#1050, carried every
English change, but it also rewrote passages whose English did not
change. This puts the reviewed text back there (the 2025 review by yuki
and Humphrey Yang, and the March 2025 text they kept) and keeps every
change the English made. Text and plot labels only: structural parity
holds, the 25 code cells match the source with strings masked, and both
math blocks are identical.

- 时间路径: nine reviewed lines, among them 主要关注的是 and its two
  bullets (yuki's), and the partition sentence, whose R is math again.
- 参数: its four reviewed lines, so 阿特克森 is Atkeson again, as in
  the rest of the lecture.
- The state list reads 易感者…移出者 again, as the intro does, with the
  English's new $S$, $E$, $I$, $R$.
- Plot labels are Chinese throughout: 人口比例 on the four y-axes that
  were English (解除封锁 already used it) and 天数 on both x-axes.

Lines that the July forward resync (#151) wrote and #302 reworded keep
#302's text. Both zh-cn rules hold on every prose line
(QuantEcon/project-translation#70).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 05:49
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 02fc39e
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/6ad9a3d71434a56a17dc146e
😎 Deploy Preview https://deploy-preview-305--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are low-risk prose restorations and string-label localizations with no code-logic or structural changes, and verified consistency in labels, state names, terminology, and font loading.

No open issues 🎉

What changed in this PR

This PR repairs lectures/sir_model.md, part of the #298 recovery effort. The prior automated sync (#302) correctly carried every English change but also rewrote five Chinese passages whose English was unchanged, discarding wording from the lecture's native 2025 review (yuki, Humphrey Yang). This PR restores the reviewed text wherever the English did not change, preserves every change the English did make, and resolves two consistency defects (bilingual plot labels and mismatched state names), bringing the Chinese edition back in line with its reviewed state while staying structurally aligned to the source.

Changes:

  • Restore reviewer wording in the 时间路径 and 参数 subsections (bullets, equation lead-ins, the $R(t)$-vs-$R$ note, and Atkeson instead of 阿特克森), with ASCII punctuation converted to full-width.
  • Align the SEIR state list (line 84) with the intro's reviewed names (易感者…移出者) while keeping the English's new $S$, $E$, $I$, $R$ math.
  • Localize remaining English plot labels to Chinese ('days'→'天数', 'fraction of the population'→'人口比例').
File Description
lectures/​sir_model.md Restores 2025 reviewer wording where English is unchanged, aligns state names with the intro, and localizes the remaining English plot labels to Chinese.

Review effort: Balanced

@mmcky
mmcky merged commit 86b86e5 into main Oct 22, 2026
7 checks passed
@mmcky
mmcky deleted the recover/sir-model-review-wording branch October 22, 2026 05:55
@github-actions

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request October 22, 2026 06:01 Inactive
mmcky added a commit to QuantEcon/action-translation that referenced this pull request Oct 22, 2026
… published (#413)

The log 2026-10-22-forward-language-codes covers:

- the zh-cn delivery of QuantEcon/lecture-python.myst#1055 and its
  human-edit review;
- #348, landed by PR #412;
- the four forward lectures that needed no forward run;
- the sir_model repair (QuantEcon/lecture-python.zh-cn#305);
- the publish and its live-site checks;
- the updates to #349, #280 and #295.

STATE.md: the release paragraph's next step is done, so Malayalam's
state-file backfill and sync-scope wiring now lead.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
pull request — 02fc39e5 Deployed Oct 22, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants