Repository navigation
sir_model: restore the 2025 reviewers' wording lost in #302 - #305
Conversation
#302, the sync of QuantEcon/lecture-python.myst#1050, carried every English change, but it also rewrote passages whose English did not change. This puts the reviewed text back there (the 2025 review by yuki and Humphrey Yang, and the March 2025 text they kept) and keeps every change the English made. Text and plot labels only: structural parity holds, the 25 code cells match the source with strings masked, and both math blocks are identical. - 时间路径: nine reviewed lines, among them 主要关注的是 and its two bullets (yuki's), and the partition sentence, whose R is math again. - 参数: its four reviewed lines, so 阿特克森 is Atkeson again, as in the rest of the lecture. - The state list reads 易感者…移出者 again, as the intro does, with the English's new $S$, $E$, $I$, $R$. - Plot labels are Chinese throughout: 人口比例 on the four y-axes that were English (解除封锁 already used it) and 天数 on both x-axes. Lines that the July forward resync (#151) wrote and #302 reworded keep #302's text. Both zh-cn rules hold on every prose line (QuantEcon/project-translation#70). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are low-risk prose restorations and string-label localizations with no code-logic or structural changes, and verified consistency in labels, state names, terminology, and font loading.
No open issues 🎉
What changed in this PR
This PR repairs lectures/sir_model.md, part of the #298 recovery effort. The prior automated sync (#302) correctly carried every English change but also rewrote five Chinese passages whose English was unchanged, discarding wording from the lecture's native 2025 review (yuki, Humphrey Yang). This PR restores the reviewed text wherever the English did not change, preserves every change the English did make, and resolves two consistency defects (bilingual plot labels and mismatched state names), bringing the Chinese edition back in line with its reviewed state while staying structurally aligned to the source.
Changes:
- Restore reviewer wording in the 时间路径 and 参数 subsections (bullets, equation lead-ins, the
$R(t)$ -vs-$R$ note, andAtkesoninstead of阿特克森), with ASCII punctuation converted to full-width. - Align the SEIR state list (line 84) with the intro's reviewed names (
易感者…移出者) while keeping the English's new$S$, $E$, $I$, $R$math. - Localize remaining English plot labels to Chinese (
'days'→'天数','fraction of the population'→'人口比例').
| File | Description |
|---|---|
| lectures/sir_model.md | Restores 2025 reviewer wording where English is unchanged, aligns state names with the intro, and localizes the remaining English plot labels to Chinese. |
Review effort: Balanced
… published (#413) The log 2026-10-22-forward-language-codes covers: - the zh-cn delivery of QuantEcon/lecture-python.myst#1055 and its human-edit review; - #348, landed by PR #412; - the four forward lectures that needed no forward run; - the sir_model repair (QuantEcon/lecture-python.zh-cn#305); - the publish and its live-site checks; - the updates to #349, #280 and #295. STATE.md: the release paragraph's next step is done, so Malayalam's state-file backfill and sync-scope wiring now lead. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Part of #298. #302, the sync of QuantEcon/lecture-python.myst#1050, carried every English change into
sir_model, but it also rewrote passages whose English did not change. The lecture carries a native review from 2025 (yuki, Humphrey Yang), and five of the twenty lines still attributed to that review were among the rewritten ones. This PR puts the reviewed text back where the English is unchanged and keeps every change the English made, in the manner of #304'svar_dmdcommit.What changes
Ris math againset_xlabel('days')twice,ylabel='fraction of the population'four times'天数','人口比例'Where the restored text had ASCII quotes or parentheses, they are now full-width, as the zh-cn rules require.
What keeps #302's text
odeintin code font, the reworded captions, and the code.dfcvsentence.Checks
mainholds under the engine's guard at QuantEcon/action-translationf89f061. The 25 code cells match the source with string literals and comments masked; the only difference is this edition's font block. Both math blocks are byte-identical.mainand this branch have none.translate statusstill readssir_modelasALIGNED. The state file is unchanged, because the source is.sir_modelin 2.85 s. Its log has noExecuting notebook failed(The -W gate is blind in ci.yml, and a warning-only cache failure discards a completed execution #271), no traceback and no missing-glyph warning, and the HTML build succeeded.The branch is a
recover/branch, so the rebase automation neither triggers on it nor rebases it, as with #300 and #301.Not in this PR: the July forward resync (#151) had already dropped 26 of the reviewers' 47 lines in this lecture, before #302. Whether to restore those belongs with the audit of forward-written text (QuantEcon/action-translation#154), not with this repair.
🤖 Generated with Claude Code