Skip to content

Fix prose typos in functions and OOP lectures - #635

Closed
SwetaKumari7 wants to merge 1 commit into
QuantEcon:mainfrom
SwetaKumari7:fix-prose-typos
Closed

SwetaKumari7 wants to merge 1 commit into
QuantEcon:mainfrom
SwetaKumari7:fix-prose-typos

Conversation

@SwetaKumari7

Copy link
Copy Markdown

Summary

This PR fixes the prose and typo issues listed in #633 across:

  • lectures/functions.md
  • lectures/oop_intro.md
  • lectures/python_oop.md

The changes correct wording, spelling, punctuation, and Markdown formatting without changing the lecture content or code behavior.

Closes #633

@SwetaKumari7

Copy link
Copy Markdown
Author

Thanks! The changes for #633 are ready for review. The PR has no conflicts, and the available checks have completed successfully.

@SwetaKumari7

Copy link
Copy Markdown
Author

Hi maintainers, just following up on this PR. The typo and prose corrections are ready for review. Please let me know if any changes are needed. Thank you!

@mmcky

mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you @SwetaKumari7, and I'm sorry this waited so long for a review.

#637 fixes the same list from #633 and also includes the two lines this PR leaves out: "for some $t$" in functions.md (the one #633 marks as mattering most, because all four translations copy it) and __init__ in python_oop.md. So I've merged #637 and am closing this one.

This PR also removed the blank line after the factorial() sentence in functions.md, which is why it now conflicts with #638, merged today. Thanks again for the careful work.

@mmcky mmcky closed this Nov 2, 2026
@SwetaKumari7

Copy link
Copy Markdown
Author

Thank you for reviewing my PR and explaining the overlap. No worries about the delay! I'll keep contributing and look for other improvements in the project. I appreciate your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prose typos in functions, oop_intro and python_oop (found via French edition review)

2 participants