Skip to content

🌐 [translation-sync] Fix prose typos in functions and OOP lectures - #103

Open
mmcky wants to merge 6 commits into
mainfrom
translation-sync-2026-11-02T09-28-36-pr-637
Open

mmcky wants to merge 6 commits into
mainfrom
translation-sync-2026-11-02T09-28-36-pr-637

Conversation

@mmcky

@mmcky mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#637 - Fix prose typos in functions and OOP lectures

Files Updated

  • ✏️ lectures/functions.md
  • ✏️ .translate/state/functions.md.yml
  • ✏️ lectures/oop_intro.md
  • ✏️ .translate/state/oop_intro.md.yml
  • ✏️ lectures/python_oop.md
  • ✏️ .translate/state/python_oop.md.yml

Details

  • Source Language: en
  • Target Language: fr
  • Model: claude-sonnet-5

This PR was created automatically by the translation action.

@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Nov 2, 2026
Copilot AI balanced review requested due to automatic review settings November 2, 2026 09:28
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-11-02
Routing: editor — 1 minor finding(s) in gating categories (accuracy/terminology/syntax/diff-check/other)
Shadow gate: would NOT auto-merge (recorded only; no action taken)


📝 Translation Quality

Criterion Score
Accuracy 9/10
Fluency 9/10
Terminology 9/10
Formatting 9/10
Overall 9/10

Summary: The translation of the modified sections is accurate, fluent, and terminologically consistent with the provided glossary. No syntax errors were found in code blocks, math blocks, or MyST directives. Minor stylistic nits exist (slight softening of 'returns an error' and a literal rendering of a sentence about recursion), but these do not affect comprehension or technical correctness. Overall this is a high-quality, publication-ready translation of the changed content. Consistent and correct use of glossary terminology (e.g., 'état stationnaire', 'surplus du consommateur/producteur', 'espace de nommage') French typographic conventions (non-breaking spaces before high punctuation, guillemets for quoted words like « face », « alias ») are properly applied in the changed sections Code blocks, math blocks, and MyST directives are preserved intact with no structural breakage across all three files

Suggestions:

  • [minor · accuracy] lectures/functions.md — ### Adding Conditions: The English says the function should return 'either standard normals or uniform random variables on (0, 1)'. The translation renders 'standard normals' as 'variables normales centrées réduites', which per the glossary is correct for random draws ('variable normale centrée réduite'), but the plural/phrasing 'des variables normales centrées réduites' is slightly heavier than necessary; this is acce…
  • [minor · fluency] lectures/python_oop.md — ### Example: A Consumer Class: The phrase 'une méthode spend, où spend(x) diminue la richesse de x, ou affiche un message si les fonds sont insuffisants' slightly paraphrases the English ('returns an error if insufficient funds exist') by saying 'affiche un message' instead of something closer to 'signale une erreur'. This is a minor accuracy drift since the code actually just prints a message rather than raising/returning an … → une méthode spend, où spend(x) diminue la richesse de x, ou renvoie une erreur si les fonds sont insuffisants
  • [nit · fluency] lectures/functions.md — ## Recursive Function Calls (Advanced): The translation of 'Basically, a recursive function is a function that calls itself' as 'Fondamentalement, une fonction récursive est une fonction qui s'appelle elle-même' is accurate but slightly literal; this is a stylistic nit only, not an error.

🔍 Diff Quality

Check Status
Scope Correct ✅
Position Correct ✅
Structure Preserved ✅
Heading-map Correct ✅
Overall 10/10

Summary: The translation sync correctly updated the same three files, in matching positions, preserving structure and heading-map metadata, with only minor inconsequential whitespace differences.

Issues:

  • Minor blank-line formatting changes in oop_intro.md (around '## Objets', '## Un petit mystère', '## Résumé') don't have an exact visible counterpart in the shown source diff, though they don't break structure or scope.
  • Translation of 'their' -> 'leurs objets' and factorial exercise fix appear correctly mapped to source edits.

This review was generated automatically by action-translation review mode.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change only applies correct English typo fixes, grammatically sound French prose tweaks, harmless cosmetic blank-line adjustments, and consistent translation-state metadata bumps, leaving no objective issues to flag.

No open issues 🎉

What changed in this PR

This is an automated translation-sync PR (fr target of QuantEcon/lecture-python-programming, source PR #637) that mirrors upstream prose/typo fixes into three French lecture files and bumps their translation-state metadata. It fits the repo's mechanical translation workflow where .translate/state/<lecture>.md.yml tracks sync provenance.

Changes:

  • Fix English typos in python_oop.md code strings ("inital"→"initial", "Insufficent"→"Insufficient").
  • Tidy French prose and remove stray blank lines in oop_intro.md; refine wording in functions.md.
  • Update .translate/state/*.yml metadata (source-sha, model, mode, tool-version) to reflect the new sync.
File Description
lectures/​python_oop.md Corrects two English spelling typos inside code-cell strings
lectures/​oop_intro.md Minor French prose refinements and removal of redundant blank lines
lectures/​functions.md Wording refinement ("complètement"→"entièrement") and a blank-line insertion
.translate/​state/​python_oop.md.yml Metadata bump: source-sha, synced-at, model, mode, tool-version
.translate/​state/​oop_intro.md.yml Metadata bump: source-sha, synced-at, model, mode, tool-version
.translate/​state/​functions.md.yml Metadata bump: source-sha only (other fields already current)

I verified the changed files in context: the English typo fixes are correct, the French prose changes are grammatically sound, the blank-line adjustments are cosmetic and harmless in MyST/Markdown, and the state-file metadata updates are consistent with the repository's translation-sync workflow. I found no objective issues warranting a comment.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-103--verdant-toffee-3261a8.netlify.app

Commit: ee9017b

📚 Changed Lectures


Build Info

@mmcky

mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@Honaminto — could you review this sync before it merges? It follows QuantEcon/lecture-python-programming#637, which corrected typos in the English of functions, oop_intro and python_oop.

Two lines change more than the English did:

  • functions.md: « nous débarrasser complètement des conditions » becomes « nous débarrasser entièrement des conditions » (the English only corrected "all together" to "altogether").
  • oop_intro.md: « Se rappeler que tout est un objet vous aidera à interagir avec vos programmes » becomes « Se rappeler que tout est un objet aide à interagir avec les programmes » (the English only corrected "Remember" to "Remembering").

If you prefer the earlier wording for either, say so and I'll restore it before merging. The rest is as expected: « leurs objets » in oop_intro.md, two corrected strings in the python_oop.md code, and a few doubled blank lines removed before headings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants