Skip to content

🌐 [translation-sync] Fix prose typos in functions and OOP lectures - #178

Merged
mmcky merged 6 commits into
mainfrom
translation-sync-2026-11-02T09-29-29-pr-637
Nov 2, 2026
Merged

mmcky merged 6 commits into
mainfrom
translation-sync-2026-11-02T09-29-29-pr-637

Conversation

@mmcky

@mmcky mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#637 - Fix prose typos in functions and OOP lectures

Files Updated

  • ✏️ lectures/functions.md
  • ✏️ .translate/state/functions.md.yml
  • ✏️ lectures/oop_intro.md
  • ✏️ .translate/state/oop_intro.md.yml
  • ✏️ lectures/python_oop.md
  • ✏️ .translate/state/python_oop.md.yml

Details

  • Source Language: en
  • Target Language: fa
  • Model: claude-sonnet-5

This PR was created automatically by the translation action.

@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Nov 2, 2026
Copilot AI balanced review requested due to automatic review settings November 2, 2026 09:29
@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Nov 2, 2026
@netlify

netlify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for majestic-griffin-10b166 ready!

Name Link
🔨 Latest commit a0c2f28
🔍 Latest deploy log https://app.netlify.com/projects/majestic-griffin-10b166/deploys/6ae85804c64789b099825703
😎 Deploy Preview https://deploy-preview-178--majestic-griffin-10b166.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-11-02
Routing: editor — 1 minor finding(s) in gating categories (accuracy/terminology/syntax/diff-check/other); accuracy 8 below floor 9; terminology 8 below floor 9
Shadow gate: would NOT auto-merge (recorded only; no action taken)


📝 Translation Quality

Criterion Score
Accuracy 8/10
Fluency 8/10
Terminology 8/10
Formatting 9/10
Overall 8.2/10

Summary: The translation of the changed sections is accurate, fluent, and terminologically consistent, with correct preservation of code blocks, math, and MyST syntax. Minor stylistic issues exist (e.g., slight expansions/softenings in explanatory sentences, inconsistent dot-notation rendering), but none affect comprehension or technical correctness. No blocking or major issues were found in the modified sections. Technical code blocks, LaTeX math, and MyST directives are preserved accurately across all three files Terminology for OOP concepts (attribute → ویژگی/صفت, method → متد, instance → نمونه) is applied consistently with the glossary Long technical explanations (e.g., recursive functions, Solow growth model, Consumer class) are translated with clear, accurate academic Persian prose

Suggestions:

  • [minor · fluency] lectures/functions.md — ### Adding Conditions: The sentence '()x.len' reversed parentheses placement is inconsistent with earlier usage like ()sqrt and ()print where parentheses appear before the method name rather than following Python's actual dot notation (x.len()). This stylistic choice (used throughout) could confuse readers trying to map it to real Python syntax, though it is applied consistently. → Consider using x.len() consistently to match actual Python syntax instead of ()x.len.
  • [minor · accuracy] lectures/functions.md — ## Recursive Function Calls (Advanced): The phrase 'در مراحل بعدی برنامه‌نویسی خود' is a reasonable rendering of 'at some stage of your programming career,' but 'career' (حرفه/مسیر شغلی) is softened to 'مراحل بعدی' (later stages), slightly losing the career-long framing of the original. → Consider 'در مسیر حرفه‌ای برنامه‌نویسی خود' to better reflect 'career'.
  • [minor · fluency] lectures/python_oop.md — ## Overview: The added introductory sentence 'در گذشته، بیشتر زبان های برنامه‌نویسی مانند... طراحی شده بودند' is an expansion not present in the English source paragraph structure for this exact spot (it preemptively explains procedural programming before the English text does), which slightly changes the flow versus the source's more concise opening. → Keep closer to source conciseness, e.g., merge the extra explanatory sentence with the existing procedural paradigm description rather than adding a new lead sentence.
  • [nit · terminology] lectures/python_oop.md — ### Example: A Consumer Class: English 'buy' method mentioned in Overview text is not actually used in the Consumer class example (only earn/spend are), this is consistent with source so not an error, but translators kept 'buy' as untranslated inline code which is fine per policy.

🔍 Diff Quality

Check Status
Scope Correct ✅
Position Correct ✅
Structure Preserved ✅
Heading-map Correct ✅
Overall 10/10

Summary: All three files (functions.md, oop_intro.md, python_oop.md) were correctly updated with corresponding fixes in matching positions, and translation metadata was appropriately left unchanged since no headings were altered.


This review was generated automatically by action-translation review mode.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The automated translation-sync changes were all verified against upstream source PR #637 with no blocking issues, leaving no active concerns to address.

No open issues 🎉

What changed in this PR

This is an automated translation-sync PR for the Farsi (fa) translation of QuantEcon's lecture-python-programming. It propagates the prose/typo fixes from upstream source PR #637 into the translated lectures and updates the corresponding translation-state metadata. All changes were verified against the source diff: English code-cell docstrings/strings are copied verbatim (inital→initial, Insufficent→Insufficient), while surrounding prose is translated, and the $t$ math formatting and __init__ reference fixes correctly mirror the source.

Changes:

  • Typo fixes in python_oop.md code comments and Persian prose (__init_→__init__).
  • Prose rephrase and $t$ math-delimiter fix in functions.md.
  • Metadata bumps in .translate/state/*.yml (source-sha → e2d28d0…, synced-at, model, mode: UPDATE, tool-version).
File Description
lectures/​python_oop.md Fixes inital→initial and Insufficent→Insufficient in English code comments, and __init_→__init__ in Persian prose; matches source verbatim for code.
lectures/​functions.md Prose rephrase (کاملاً→به‌طور کامل) and adds $t$ math delimiters; mirrors source altogether/$t$ fixes. Also adds one spurious (harmless) blank line not present upstream.
lectures/​oop_intro.md No-op trailing code-fence re-write; no content change.
.translate/​state/​functions.md.yml Updates source-sha to the synced source commit.
.translate/​state/​python_oop.md.yml Metadata update (source-sha, synced-at, model, mode, tool-version).
.translate/​state/​oop_intro.md.yml Metadata update (source-sha, synced-at, model, mode, tool-version).

No blocking issues were identified; the translation faithfully reflects the upstream typo fixes and the metadata is internally consistent.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

@mmcky
mmcky merged commit 4bc7b66 into main Nov 2, 2026
10 of 12 checks passed
@mmcky
mmcky deleted the translation-sync-2026-11-02T09-29-29-pr-637 branch November 2, 2026 09:34

This branch was successfully deployed

1 active deployment
pull request — a0c2f28d Deployed Nov 2, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants