Repository navigation
Conversation
Send a `user-signed-up` PostHog event when the onboarding creates the organization, instead of posting the sign-up to Cargo. A PostHog → HubSpot destination now creates the contact and company as an inbound lead and submits the "Trial - All" form, as Cargo did. Remove the Cargo hook and the NX_PUBLIC_CARGO_API_TOKEN variable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit cb3071b
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #3187 +/- ##
===========================================
- Coverage 56.39% 55.29% -1.11%
===========================================
Files 944 1375 +431
Lines 24242 30898 +6656
Branches 7637 9452 +1815
===========================================
+ Hits 13672 17085 +3413
- Misses 8435 11214 +2779
- Partials 2135 2599 +464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… helper The UTM capture hook was no longer called since the new UI moved to TanStack Router, so the sign-up event always sent null attribution. Call useCaptureUtmParams in App again, before the Auth0 redirect, and read the stored values with a new getStoredUtmParams in shared/util-hooks instead of an onboarding-local copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/console/src/main.tsx">
<violation number="1" location="apps/console/src/main.tsx:190">
P2: This startup call can throw when browser storage is blocked or full, preventing the console from loading for affected users. Make `useCaptureUtmParams` tolerate `localStorage.setItem` failures, as `getStoredUtmParams` already does.</violation>
</file>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Sign-ups no longer go to Cargo. When onboarding creates the organization, the Console sends a
user-signed-upPostHog event, and a PostHog → HubSpot destination does what Cargo used to do.user-signed-upevent is sent once, from the completion step that creates the organization, after the profile form. It carries:organization_id,signup_source: Console;gclid.useSignUpCargoand theNX_PUBLIC_CARGO_API_TOKENenv var, including in the build workflow.useCreateUserSignUpno longer tracks anything.lead_source = Inbound. Personal email domains are skipped. The company is resolved before the contact so HubSpot's auto-association doesn't create a duplicate.lifecyclestage = leadandcontact_source = Inbound, and associates it with the company. An existing lifecycle stage is never downgraded.After merge
NX_PUBLIC_CARGO_API_TOKENfrom the GitHub repository variables.Test plan
domains-onboarding-featureanddomains-users-sign-up-featurepass.lead_source = Inbound;lead/Inboundand associated with that company;🤖 Generated with Claude Code
Summary by cubic
Sign-ups no longer go to Cargo: onboarding now sends a
user-signed-upPostHog event when it creates the organization, and a PostHog → HubSpot destination handles the lead like Cargo did.organization_id,signup_source: Console, and attribution params.main.tsx(it stopped working after the move to TanStack Router), and reads stored values via a newgetStoredUtmParamshelper instead of an onboarding-local copy. Capture is best-effort and never breaks app startup whenlocalStorageis unavailable.useSignUpCargoand theNX_PUBLIC_CARGO_API_TOKENenv var, including from the build workflow.After merge
NX_PUBLIC_CARGO_API_TOKENfrom the GitHub repository variables.Written for commit cb3071b. Summary will update on new commits.