[hCoureau]

Parse Q10 obstacle and skip-clean point tables using their declared counts and section boundaries, and render position-only obstacle markers. Truncated tables do not shift parsing into following sections.

Obstacle coordinates remain on Q10MapPacket. Q10Obstacle is a standalone RoborockBase model with its own 50-units-per-pixel header transform, separate from trace coordinates. Drawable configuration is forwarded through the Q10 factory. No obstacle type, confidence or photo identifier is inferred.

Validation

• Full pytest suites on Python 3.11 and 3.14: 2,058 passed, 53 xfailed on each. The repository’s default configuration excludes 11 MQTT-broker tests.
• Focused suites: 120 passed.
• All pre-commit checks and wheel/source distribution builds passed.

Rebuilt independently on upstream main (8e471dc, 7.15.2), without cumulative feature dependencies. No physical-device validation was run for this revision. Related: #767.

[lboue]

@hCoureau Could you fix the conflict?

[hCoureau]

Resolved the merge conflicts with current main in ded170d by merging main and retaining its accepted 30-second Q10 CLI map-push timeout. The PR's feature changes are preserved. GitHub now reports this PR as conflict-free, and it remains ready for review.

Validation: 1,026 tests passed, 92 snapshots passed, all pre-commit hooks passed, and sdist/wheel builds passed. GitHub CI was triggered for the new head. Required maintainer approval still applies.

The existing stacked dependencies on #936 and #937 still apply; this update does not bypass their review or merge order. Conflict resolution and validation performed with OpenAI Codex assistance.

[allenporter]

Note: Conducting this code review following our /review skill using Antigravity (AGY) and Gemini 4 Argon.

The map parser and renderer changes for decoding the post-carpet obstacle/skip-clean point tables and drawing Drawable.OBSTACLES look clean and well-bounded.

A few architectural and scoping items to simplify this PR:

1. Decouple from #937 and keep raw obstacle coordinates internal to the map packet/renderer:

   • Neither V1 (v1/map_content.py) nor Q7 (b01/q7/map_content.py) exposes a separate obstacles or detail_obstacles property on MapContentTrait, CleanSummaryTrait, or MapsTrait—obstacles are parsed on the map packet and rendered into the map image (image_content / MapData.obstacles).
   • Moreover, Q10Obstacle is in an internal raw map-packet coordinate frame (50 raw units/pixel relative to the internal map header origin), which isn't usable by a trait consumer without Q10HeaderCalibration.
   • If we keep obstacles and skip_cleaning_points on Q10MapPacket for the parser and renderer and drop map.obstacles, clean_history.detail_obstacles, and maps.detail_obstacles, this PR no longer depends on #937 (since #936 is already merged into main) and can be rebased directly onto main.

2. Avoid Q10Obstacle(Q10Point) inheritance and stringified forward references in b01_q10_map_parser.py:

   • See inline comments on Q10Obstacle inheriting Q10Point.to_roborock() (which applies the 2.5 mm trace scale factor rather than the 50 raw units/pixel obstacle scale) and the stringified forward references on Q10MapPacket.

3. Test public behavior rather than private renderer helpers / patched factory call_args:

   • See inline comments on tests/map/test_b01_q10_render.py and tests/devices/test_device_manager.py.

[Lash-L]

Marking as draft since there are some outstanding comments!

[allenporter]

Thank you @hCoureau for the awesome improvement! Much appreciated as a Q10 owner myself.