Skip to content

docs: add adversarial self-check to code-review skill - #1020

Merged
allenporter merged 1 commit into
Python-roborock:mainfrom
allenporter:code-review-adversarial-check
Nov 8, 2026
Merged

allenporter merged 1 commit into
Python-roborock:mainfrom
allenporter:code-review-adversarial-check

Conversation

@allenporter

@allenporter allenporter commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Update the review skill since it seemed a little nitpicky on the last few rounds, and it's proposals made PRs worse.

Details:

  • Clarify in .agents/skills/code-review/SKILL.md that device.features capability gating applies to option/command/trait exposure (and genuinely overloaded wire codes), rather than over-gating unambiguous read-only telemetry decoding (from_code_optional()).
  • Add an explicit Adversarial Self-Check on Candidate Findings step before formatting or posting review feedback:
    • Verify suggested diffs against upstream/main baseline behavior and git log history so suggestions do not silently regress valid inputs or duplicate bounds.
    • Check sibling cases/codes in the same module to confirm stated invariants hold across the codebase.
    • Independently scrutinize claims from prior or competing PR reviews rather than carrying them forward uncritically.
    • Drop low-value docstring/comment wording nits and report cleanly when a PR has zero defects.

Copilot AI balanced review requested due to automatic review settings November 8, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@allenporter
allenporter merged commit 9d73026 into Python-roborock:main Nov 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants