Repository navigation
👽️ [Artifact 3, 7] 信仰の判定を is_believe の predicate から本体の API に置き換える - #2225
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
tatuharu
reviewed
Nov 2, 2026
tatuharu
left a comment
Member
There was a problem hiding this comment.
このレビューはハルがAI自動レビューの動作テストのためにOpus5.5 Extra Highを使用してレビューを行なったものです。鵜呑みにせず、指摘を採用するかはお任せします。
指摘はありません。
EllaCoat
enabled auto-merge (squash)
November 2, 2026 11:29
ChenCMD
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ProjectTSB/TheSkyBlessing#2330 で信仰の predicate
player_manager:is_believe/*を消すのに合わせ、神器 0003・0007 の信仰判定を本体の APIapi:entity/player/is_believe/*に置き換えた。主な変更
信仰を見る 2 つの神器の判定を、
execute if functionで API を呼んで行うようにした。動作確認
実サーバーで変更前(master)と比べ、DevPrivilege を持たない人はすべての信仰で同じ結果だった。
未対応・注意
ProjectTSB/TheSkyBlessing#2330 を先に merge し、declares が作り直されたら、この PR の CI をやり直してから merge する。
lintは解決できない関数 7 件で落ちているdeclares.dは bot が作り直すので、この PR では触っていないis_believe/nullを使っていて、api:entity/player/is_believe/noneへの書き換えが要る