Repository navigation
Conversation
This was referenced Nov 1, 2026
EllaCoat
marked this pull request as ready for review
November 2, 2026 11:39
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
tatuharu
reviewed
Nov 2, 2026
tatuharu
left a comment
Member
There was a problem hiding this comment.
このレビューはハルがAI自動レビューの動作テストのためにOpus5.5 Extra Highを使用してレビューを行なったものです。鵜呑みにせず、指摘を採用するかはお任せします。
指摘はありません。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
神器の入口を function tag ではなく give の宣言から呼ぶ本体の変更に合わせ、Asset の神器とテンプレートを新しい宣言の形に書き換えた。ProjectTSB/TheSkyBlessing#2327 と組の PR で、ProjectTSB/TheSkyBlessing#2327 をマージした後にマージする。
主な変更
既存の神器の宣言を一回限りのスクリプトで機械的に書き換え、テンプレートとナレッジの説明を新しい形に合わせた。スクリプトは repo に置いていない。
NamespaceとTriggersを足したTrigger568 個をLoreTriggerに改名した(値と説明の行はそのまま)dispatch/call.mから呼ばれるので、入口の関数 627 本の@withinを変え、event の tag 61 個を削除したTriggersに書き、tag へ追記するテンプレート 58 個を削除したNamespace・Triggersの説明の行をテンプレートと同じ短い形にしたdocs/knowledgeの 2 ファイルで、tag で入口を呼ぶ説明をTriggersで宣言する説明に直した動作確認
本体 ProjectTSB/TheSkyBlessing#2327 の実サーバーでの確認とテンプレートの検査を、この PR の変更込みで行い、CI の lint も通った。
3.mainまで呼ばれ、thisに Field の中身だけが入り、説明文にfield_text.mの文字列が出た未対応・注意
マージ後は神器の入口を event の tag ではなく give の
Triggersに書き、宣言を変えたら give を実行し直す。asset:rejoinの tag で呼ぶ処理 22 本は、今までどおり tag で呼ぶTriggersに{Event:"dis_equip",Entry:"trigger/dis_equip/"}を手で足す