Repository navigation
Add tests pinning console output and removal quirks - #71
Merged
dmccoystephenson merged 1 commit intoNov 4, 2026
Merged
Conversation
Pin printConsoleRepresentation's layout, getFirstEntity's location order, and the removal behaviour of duplicated and same-id entities. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (run inline in this session, so it is not an independent review):
Gaps noted:
Do-not-auto-merge paths: none matched. No workflow, This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/pin-console-output-and-removal-quirks
branch
November 4, 2026 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle. The open-issue backlog was empty at triage, and
Environment::printConsoleRepresentation()was the one public behaviour-bearing method with no test exercising it. No production code is changed.printConsoleRepresentation(): the row-by-row layout, the[x]and[ ]cells, and the misalignment aftersetSizethat the README already describes.getFirstEntityfollowing location order rather than insertion order.Grid::removeLocationleaves an entity's environment id unchanged.Grid::addLocationstores a copy of its argument.false, including the random move.README.mddocuments the behaviours that were previously undocumented (getFirstEntity order, the console cell format, twin removal, and the one-pointer-per-location removal).Test 66 characterizes behaviour that is believed to be a bug. It is filed as #70 and is deliberately not fixed here; the fix should update Test 66 and the matching README paragraph. This PR therefore does not close #70.
No tracking issue — gap found during triage.
Test plan
makecompiles the suite locallyLibrary tests (make + CMake)job shows everyTest N - ...through Test 68 followed by--- Success(local execution of the binary is denied in this environment, so the CI job is the anchor)test*()function is registered inmain()This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson