Repository navigation
Give the UK qualify job 330 minutes - #660
Merged
Merged
Conversation
Since #651 the wrapper.household contract rows run the household calculator instead of erroring at once, and with contract 2.0.0 the local gates pass two hours. The 120-minute limit cancelled every attempt and the catch-up re-staged it, so no candidate has finished its gates since 17 October. Fixes #659 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Merged at 6588f78 (merge commit above). Audit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #659
The UK qualify job hits its 120-minute timeout on every attempt ("The job has exceeded the maximum execution time of 2h0m0s", run 39145419501). The catch-up then re-stages the attempt, so no candidate has finished its gates since 17 October around 14:30Z; 2.135.6 has been staged seven times.
Cause: before #651, every
wrapper.householdcontract row errored at once (policyengine.ukwas None), and the gates took 80–89 minutes. #651 made those rows run the household calculator, which takes the gates past two hours. Attempts with #651 but not #627 timed out too, so contract 2.0.0 isn't the cause. Projected total is about 135–145 minutes, per the independent review's log analysis. The cancelled log shows active computation up to the cut-off, not a hang.Change:
timeout-minutes: 330on the qualify job, with a comment saying why. That's under the 360-minute ceiling for GitHub-hosted jobs. The job's concurrency group (uk-candidate-<pair>,cancel-in-progress: false) already stops later runs from cancelling it, and the replay job keeps its 355. No code or test changes. The workflow tests don't pin this value, and the YAML parses with qualify at 330.Follow-ups (not here):
Independent review (Opus, in-session): VERDICT: AGREE. It confirmed the timeout annotation on 4 jobs, that all 15 qualify jobs since #651 were cancelled at about 2h00m20s, and that the ledger durations bear this out. The YAML is valid, the workflow tests pass 24/24, and concurrency and replay are unaffected.
🤖 Generated with Claude Code