Skip to content

Clarify the Pension Credit qualifying-age documentation - #2467

Open
juaristi22 wants to merge 1 commit into
mainfrom
docs-2162-pension-credit-qualifying-age
Open

juaristi22 wants to merge 1 commit into
mainfrom
docs-2162-pension-credit-qualifying-age

Conversation

@juaristi22

Copy link
Copy Markdown
Collaborator

Refs #2162 (item 1 only).

Clarify the documentation for has_attained_state_pension_credit_qualifying_age: men born on 6 November 1953 reach the qualifying age and their own State Pension age at 65. This qualifies the general statement about men born before 6 December 1953. The existing formula, parameters and 6 October annual convention are retained.

The exception follows the same-birth-date rule in section 1(6) and the Pensions Act 1995 Schedule 4 timetable.

This addresses the documentation point only; #2162 remains open for its other follow-ups, which have separate work in #2358 and #2324.

Validation: the complete module AST matches main after excluding only the documentation value. Three existing qualifying-age regression checks passed; all 18 protected source, parameter, test and dependency files retain their original hashes. No new policy test or runtime correction is claimed. Independent policy/source and code reviews completed with no findings. Hosted CI will be checked after publication.

axiom: n/a: documentation metadata clarification; policy formulas, parameters and calculated eligibility are unchanged.

@juaristi22 juaristi22 self-assigned this Oct 17, 2026

@vahid-ahmadi vahid-ahmadi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, fine to approve.

@juaristi22, the new wording is correct and the change is documentation only.

  1. nit: changelog.d/2162.changed.md:1 starts with - . Item 3 of the same issue says towncrier's default template adds its own bullet, so this renders as - - . It matches what main and docs/engineering/skills/github-prs.md still do, so it is fine to leave until #2324 or item 3 settles the convention.

No must or should findings.

What I checked

  • Pensions Act 1995 Sch 4 para 1 table 2 (as at 6 October 2016) on legislation.gov.uk: women born 6 November to 5 December 1953 reach pensionable age on 6 November 2018. SPCA 2002 s.1(6) ties the qualifying age to a woman born on the same day. So a man born on 6 November 1953 reaches the qualifying age on his 65th birthday. For every other birth date before 6 December 1953, the qualifying age falls before the 65th birthday. The new sentence states this correctly.
  • Compared the module AST against main (62a0117f) with only the documentation value blanked: identical. No formula, parameter or test changes.
  • ruff check and ruff format --check on the changed file: clean.
  • Hosted CI on head 078a786e: all checks pass, including Test / Python 1-4, YAML, Lint, Docs build and Fix evidence.
  • Fragment type changed fits a documentation change. The body says "Refs #2162 (item 1 only)", so the issue stays open for items 2 and 3.
  • I did not run the test suite locally, as nothing executable changed.

🤖 Generated with Claude Code

@vahid-ahmadi vahid-ahmadi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, per my review above. The shoulds and nits can follow.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants