Repository navigation
Conversation
❌ Deploy Preview for coreprotect failed. Why did it fail? →
|
CheekyNox
force-pushed
the
fix/chested-horse-inventory
branch
from
September 23, 2026 14:22
de15e94 to
df9c2c3
Compare
Contributor
|
Thanks for your contribution! Automated review is requesting the following:
|
Contributor
|
Thanks for the updates! Automated review found a few remaining compatibility issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
player-interactions, support direct inspection, and document the additional container types in the v13 API notes.src/testand restore its.gitignoreentry as requested; tests are maintained in a separate repository.Root cause
InventoryChangeListeneroriginally only recognized entity containers accepted byEntitySpawnTracking.isPlacedEntity(), excluding chested horses. A first transaction also needs to promote a natural entity into the persisted identity table before its container rows can be written.The earlier implementation then assumed
getContents()always exposed saddle/decor at indices 0 and 1. Spigot can expose one leading equipment slot or storage alone, while the GUI retains both equipment slots. Capture, saved state, and replay now share normalized snapshots and convert to the native layout when applying changes. Previously saved arrays with zero, one, or two leading slots are normalized when read.Validation
BUILD SUCCESS; shadedtarget/CoreProtect-24.1.jarverified. Repository tests are skipped by the existing POM configuration.git diff --check.A live Paper/Spigot server test was not performed.
Fixes #3