Repository navigation
Conversation
List the functionality in the decommutator that is not tested, most important first, so that tests can be added for it. About a third of the code is never run by the tests, mostly in the spacecraft housekeeping path, the handling of unusual packets, and the handling of errors. Several entries describe behavior that a test should decide on, such as functions that raise UnboundLocalError or that log an error without reporting a failure. Move the existing testing items out of the Dagster section, since most of these tests are not specific to Dagster. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a "Tests to add" section to
src/pyfaradaycup/decommutator/README.md. It lists the decommutator's untested functionality, most important first. Coverage is 67% overall:ccsds_reader_pipeline.pyis at 50%,l0_to_l05.pyat 71%, andmain.pyat 88%.The main gaps:
--spacecraft):_read_file_scand_get_layout_scare never run, including how the flight software version is chosen.spacecraft=Truescaling in_secsubsec2scetis never run, and subseconds are truncated rather than rounded (up to 20 µs early).main, plus the--gzipand PTP inputs and the CLI usage errors.Several entries describe current behavior that a test should decide on, such as:
_get_layout_scraisingUnboundLocalErrorwhen an APID's section has no( Block[line._cdf35e_35fwriting no data whilemainreports the CDF as written.The two existing testing items move out of the Dagster section into the new section, since most of these tests aren't specific to Dagster.
This changes documentation only.
🤖 Generated with Claude Code