Repository navigation
Combine Dagster and coverage tests in one Nox session - #104
Merged
Merged
Conversation
Replace the separate dagster and coverage Nox sessions with a single dagster_with_coverage session that runs the full test suite, including the Dagster tests, while measuring code coverage. Previously the Dagster tests were skipped in the coverage session, so the code they exercise was not counted toward coverage. Codecov reports are now uploaded only from this session. Move pytest-cov out of the test group into a new coverage group, along with coverage[toml] (needed for coverage to read pyproject.toml on Python < 3.11). Put codecov-cli in its own codecov group for local uploads, since codecov-action provides its own CLI in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Neither group was needed. CI uploads reports with codecov-action, which provides its own CLI, and local uploads can use uvx. pytest-cov already depends on coverage[toml], so pytest-cov goes back into the test group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dagsterandcoverageNox sessions with onedagster_with_coveragesession, which runs the full test suite on Python 3.14 with Dagster installed and measures coverage. Previously the coverage session skipped the two Dagster tests, so the code they exercise didn't count toward coverage.dagster_with_coveragein place of thecoverage-3.12anddagsterjobs, and upload to Codecov only from that job.uvx --from codecov-cli codecovcli upload-process.Dependency groups are unchanged:
pytest-covstays intest, andcodecov-cliisn't needed as a dependency becausecodecov/codecov-actionprovides its own CLI.Notes
nox -s coverage-<python>andnox -s dagsterno longer exist. Usenox -s dagster_with_coverage.Testing
nox -s dagster_with_coverage: 132 passed, 0 skipped (previously 130 passed and 2 Dagster tests skipped incoverage-3.12)nox -s zizmorpass🤖 Generated with Claude Code