Skip to content

Use ellc from PyPI instead of the bundled submodule - #36

Merged
martindevora merged 2 commits into
masterfrom
feat/ellc-pypi
Nov 7, 2026
Merged

martindevora merged 2 commits into
masterfrom
feat/ellc-pypi

Conversation

@martindevora

Copy link
Copy Markdown
Collaborator

Summary

  • Drop the tkmatrix/ellc submodule, the CustomInstall make step in setup.py and the import-time make + sys.modules['ellc'] hack in tkmatrix/__init__.py. The ravex submodule is unchanged.
  • Depend on ellc==1.9.0 from PyPI (sdist, builds libellc.so with meson at install time; gfortran is still required).

Notes

  • This moves tkmatrix from bundled ellc 1.8.11 to 1.9.0, which includes the n_int exposure-integration fix from 1.8.15, so injected light curves can change slightly when t_exp/n_int integration applies.

Tests

  • New tkmatrix/tests/test_ellc_dependency.py: installed ellc is used, and InjectModel.make_model injects a transit with ellc without falling back to batman (offline).
  • Locally: 76 passed; 9 MAST-dependent tests failed with RemoteServiceError/timeouts in lightkurve.search, before reaching ellc. CI on master passes those tests, so this PR's CI is the reference for them.

🤖 Generated with Claude Code

martindevora and others added 2 commits November 7, 2026 18:22
Drop the tkmatrix/ellc git submodule, the CustomInstall make step in setup.py
and the import-time make/sys.modules hack in tkmatrix/__init__.py. Depend on
ellc==1.9.0, which builds libellc.so with meson at install time (gfortran
still required). The ravex submodule is unchanged.

This moves tkmatrix from bundled ellc 1.8.11 to 1.9.0, which includes the
n_int exposure-integration fix from 1.8.15. Add tests checking that the
installed ellc is used and that InjectModel injects transits with ellc
without falling back to batman.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check matched the package name anywhere in the path, so it failed when
the repository was cloned into a directory with that name (e.g. GitHub
Actions). Compare against the real package directory instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@martindevora
martindevora merged commit be56783 into master Nov 7, 2026
1 check failed
@martindevora
martindevora deleted the feat/ellc-pypi branch November 7, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant