Repository navigation
Use ellc from PyPI instead of the bundled submodule - #36
Merged
Merged
Conversation
Drop the tkmatrix/ellc git submodule, the CustomInstall make step in setup.py and the import-time make/sys.modules hack in tkmatrix/__init__.py. Depend on ellc==1.9.0, which builds libellc.so with meson at install time (gfortran still required). The ravex submodule is unchanged. This moves tkmatrix from bundled ellc 1.8.11 to 1.9.0, which includes the n_int exposure-integration fix from 1.8.15. Add tests checking that the installed ellc is used and that InjectModel injects transits with ellc without falling back to batman. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check matched the package name anywhere in the path, so it failed when the repository was cloned into a directory with that name (e.g. GitHub Actions). Compare against the real package directory instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tkmatrix/ellcsubmodule, theCustomInstallmake step insetup.pyand the import-timemake+sys.modules['ellc']hack intkmatrix/__init__.py. Theravexsubmodule is unchanged.ellc==1.9.0from PyPI (sdist, buildslibellc.sowith meson at install time;gfortranis still required).Notes
n_intexposure-integration fix from 1.8.15, so injected light curves can change slightly whent_exp/n_intintegration applies.Tests
tkmatrix/tests/test_ellc_dependency.py: installed ellc is used, andInjectModel.make_modelinjects a transit with ellc without falling back to batman (offline).RemoteServiceError/timeouts inlightkurve.search, before reaching ellc. CI on master passes those tests, so this PR's CI is the reference for them.🤖 Generated with Claude Code