Repository navigation
fix(mqtt): keep reconnecting after a session takeover - #69
Merged
Merged
Conversation
Bump mqtt to 2.0.2, which keeps retrying when a reconnection drops straight away or the broker reports a protocol error, and holds application packets until the broker accepts the connection. Resync from the client's on_reconnect callback, once the broker has accepted the new connection, instead of counting transports. Log an error when the client stops for good, except when the manager replaces a publisher. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Source opened a new MQTT connection while its old one was still open, the broker took the session over, then disconnected the new connection with a protocol error, and source never tried again.
Fix
closed?stays true until then); previously the resync published ahead of the CONNACKon_reconnectcallbackMqttPublisherresyncs fromon_reconnectrather than counting transportsBrokerRelaymoved intospec_helperand gaineddrop; new spec for resyncing after a reconnectionTesting
Specs run in three batches (the full single run is OOM killed in the local Docker VM, master behaves the same): 79 examples, 0 failures.
🤖 Generated with Claude Code