Repository navigation
fix: correct backend and mixed-repo smoke failures #160
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| export interface SourceCoverageActionInput { | ||
| skippedFiles: number; | ||
| candidateBudgetExhausted?: boolean; | ||
| candidateRetrievalFailed?: boolean; | ||
| refreshAction?: string; | ||
| } | ||
|
|
||
| const SOURCE_REFRESH_ACTION = | ||
| 'Run refresh_index with incrementalOnly=true to refresh changed or unavailable sources, then retry.'; | ||
| const CANDIDATE_BUDGET_ACTION = | ||
| 'Search candidate budget was exhausted. Narrow the query to a concrete symbol or path and retry.'; | ||
|
|
||
| /** Stale or unreadable sources need a refresh. An exhausted candidate budget does not. */ | ||
| export function sourceCoverageRefreshAction(input: { | ||
| skippedFiles: number; | ||
| candidateBudgetExhausted: boolean; | ||
| candidateRetrievalFailed: boolean; | ||
| }): string | undefined { | ||
| if (input.skippedFiles > 0 || input.candidateRetrievalFailed) return SOURCE_REFRESH_ACTION; | ||
| if (input.candidateBudgetExhausted) return CANDIDATE_BUDGET_ACTION; | ||
| return undefined; | ||
| } | ||
|
|
||
| export function presentSourceCoverage<T extends SourceCoverageActionInput>(coverage: T): T { | ||
| if (coverage.skippedFiles > 0 || coverage.candidateRetrievalFailed === true) return coverage; | ||
| const refreshAction = sourceCoverageRefreshAction({ | ||
| skippedFiles: 0, | ||
| candidateBudgetExhausted: coverage.candidateBudgetExhausted === true, | ||
| candidateRetrievalFailed: false | ||
| }); | ||
| if (!refreshAction || refreshAction === coverage.refreshAction) return coverage; | ||
| return { ...coverage, refreshAction }; | ||
|
Comment on lines
+24
to
+32
Contributor
There was a problem hiding this comment.
When the index is older than seven days and the candidate budget runs out with no skipped files, Editing stays blocked, but narrowing the query does not clear the stale-index gate. Keep the stale-index refresh instruction ahead of the budget advice. |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { mkdtemp, mkdir, rm, writeFile } from 'node:fs/promises'; | ||
| import { tmpdir } from 'node:os'; | ||
| import path from 'node:path'; | ||
| import { afterEach, describe, expect, it } from 'vitest'; | ||
| import { makePaths } from '../src/project-state.js'; | ||
| import { handle } from '../src/tools/get-indexing-status.js'; | ||
| import type { ToolContext } from '../src/tools/types.js'; | ||
|
|
||
| const roots: string[] = []; | ||
|
|
||
| afterEach(async () => { | ||
| await Promise.all(roots.splice(0).map((root) => rm(root, { recursive: true, force: true }))); | ||
| }); | ||
|
|
||
| describe('indexing status disk stats', () => { | ||
| it('reports the keyword cap from persisted stats when the process has no in-memory stats', async () => { | ||
| const root = await mkdtemp(path.join(tmpdir(), 'cbc-status-cap-')); | ||
| roots.push(root); | ||
| const dir = path.join(root, '.codebase-context'); | ||
| await mkdir(dir); | ||
| await writeFile( | ||
| path.join(dir, 'indexing-stats.json'), | ||
| JSON.stringify({ | ||
| indexedFiles: 4, | ||
| totalChunks: 12, | ||
| totalFiles: 4, | ||
| generatedAt: '2026-10-30T22:40:09.166Z' | ||
| }) | ||
| ); | ||
| await writeFile( | ||
| path.join(dir, 'index.json'), | ||
| JSON.stringify({ chunks: [{ id: 'a' }, { id: 'b' }] }) | ||
| ); | ||
|
|
||
| const ctx: ToolContext = { | ||
| indexState: { status: 'ready' }, | ||
| paths: makePaths(root), | ||
| rootPath: root, | ||
| performIndexing: async () => undefined | ||
| }; | ||
| const response = await handle({}, ctx); | ||
| const payload = JSON.parse(response.content?.[0]?.text ?? '{}') as { | ||
| lastIndexed?: string; | ||
| stats?: { | ||
| indexedFiles?: number; | ||
| totalChunks?: number; | ||
| searchableChunks?: number; | ||
| omittedChunks?: number; | ||
| }; | ||
| }; | ||
|
|
||
| expect(payload.lastIndexed).toBe('2026-10-30T22:40:09.166Z'); | ||
| expect(payload.stats).toMatchObject({ | ||
| indexedFiles: 4, | ||
| totalChunks: 12, | ||
| searchableChunks: 2, | ||
| omittedChunks: 10 | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { | ||
| presentSourceCoverage, | ||
| sourceCoverageRefreshAction | ||
| } from '../src/core/source-coverage-action.js'; | ||
|
|
||
| describe('sourceCoverageRefreshAction', () => { | ||
| it('asks for a narrower query when only the candidate budget is exhausted', () => { | ||
| const action = sourceCoverageRefreshAction({ | ||
| skippedFiles: 0, | ||
| candidateBudgetExhausted: true, | ||
| candidateRetrievalFailed: false | ||
| }); | ||
| expect(action).toMatch(/candidate budget/i); | ||
| expect(action).not.toMatch(/refresh_index/); | ||
| }); | ||
|
|
||
| it('keeps refresh guidance when nominated sources were skipped', () => { | ||
| const action = sourceCoverageRefreshAction({ | ||
| skippedFiles: 2, | ||
| candidateBudgetExhausted: true, | ||
| candidateRetrievalFailed: false | ||
| }); | ||
| expect(action).toMatch(/refresh_index/); | ||
| }); | ||
|
|
||
| it('replaces a refresh instruction when the only gap is the candidate budget', () => { | ||
| const presented = presentSourceCoverage({ | ||
| skippedFiles: 0, | ||
| candidateBudgetExhausted: true, | ||
| refreshAction: | ||
| 'Run refresh_index with incrementalOnly=true to refresh changed or unavailable sources, then retry.' | ||
| }); | ||
| expect(presented.refreshAction).toMatch(/candidate budget/i); | ||
| expect(presented.refreshAction).not.toMatch(/refresh_index/); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit includes a
.planning/ROADMAP.mdupdate despite the repository's explicit guardrail against committing.planning/**without a direct user request, and its pre-commit requirement to abort when those files are staged. Remove this roadmap change from the proposed patch unless its inclusion was explicitly authorized; the public smoke results can remain indocs/benchmark.md.AGENTS.md reference: AGENTS.md:L122-L124
Useful? React with 👍 / 👎.