Skip to content

Release 3.12.1 - #412

Merged
SauravBizbRolly merged 39 commits into
mainfrom
release-3.12.1
Nov 12, 2026
Merged

Release 3.12.1#412
SauravBizbRolly merged 39 commits into
mainfrom
release-3.12.1

Merge pull request #406 from PSMRI/fix/feild_testing_issue

9dfb7cc
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 12, 2026 in 55s

Quality Gate failed

Failed conditions
10.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 475 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "objectMapper" which hides the field declared at line 104. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYn&open=AaHOLEgRqTrsVVLTbWYn&pullRequest=412

Check warning on line 83 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYl&open=AaHOLEgRqTrsVVLTbWYl&pullRequest=412

Check warning on line 1051 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "startOfMonth" local variable. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYd&open=AaHOLEcjqTrsVVLTbWYd&pullRequest=412

Check warning on line 1150 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "objectMapper" which hides the field declared at line 104. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYo&open=AaHOLEgRqTrsVVLTbWYo&pullRequest=412

Check failure on line 65 in src/main/java/com/iemr/flw/controller/GeneralCheckUpFollowUpController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "statusCode" 6 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLD8TqTrsVVLTbWYI&open=AaHOLD8TqTrsVVLTbWYI&pullRequest=412

Check warning on line 409 in src/main/java/com/iemr/flw/controller/DiseaseControlController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "@RequestMapping(method = RequestMethod.POST)" with "@PostMapping" 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEBUqTrsVVLTbWYR&open=AaHOLEBUqTrsVVLTbWYR&pullRequest=412

Check warning on line 47 in src/main/java/com/iemr/flw/controller/GeneralCheckUpFollowUpController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLD8TqTrsVVLTbWYJ&open=AaHOLD8TqTrsVVLTbWYJ&pullRequest=412

Check warning on line 1297 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "supervisorUserId". 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYi&open=AaHOLEcjqTrsVVLTbWYi&pullRequest=412

Check warning on line 1852 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYq&open=AaHOLEgRqTrsVVLTbWYq&pullRequest=412

Check warning on line 1052 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "endOfMonth" local variable. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYe&open=AaHOLEcjqTrsVVLTbWYe&pullRequest=412

Check warning on line 72 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYk&open=AaHOLEgRqTrsVVLTbWYk&pullRequest=412

Check failure on line 1654 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYp&open=AaHOLEgRqTrsVVLTbWYp&pullRequest=412

Check warning on line 1013 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly specify the time zone by passing a ZoneId or a Clock to the .now() method. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYa&open=AaHOLEcjqTrsVVLTbWYa&pullRequest=412

Check failure on line 99 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "dd-MM-yyyy" 4 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYj&open=AaHOLEgRqTrsVVLTbWYj&pullRequest=412

Check failure on line 289 in src/main/java/com/iemr/flw/controller/DiseaseControlController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "No records found" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEBUqTrsVVLTbWYO&open=AaHOLEBUqTrsVVLTbWYO&pullRequest=412

Check warning on line 766 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYX&open=AaHOLEcjqTrsVVLTbWYX&pullRequest=412

Check warning on line 1402 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYU&open=AaHOLEcjqTrsVVLTbWYU&pullRequest=412

Check warning on line 90 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYV&open=AaHOLEcjqTrsVVLTbWYV&pullRequest=412

Check warning on line 116 in src/main/java/com/iemr/flw/service/impl/DiseaseControlServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEgRqTrsVVLTbWYm&open=AaHOLEgRqTrsVVLTbWYm&pullRequest=412

Check warning on line 381 in src/main/java/com/iemr/flw/controller/DiseaseControlController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "@RequestMapping(method = RequestMethod.POST)" with "@PostMapping" 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEBUqTrsVVLTbWYQ&open=AaHOLEBUqTrsVVLTbWYQ&pullRequest=412

Check warning on line 52 in src/main/java/com/iemr/flw/controller/DiseaseControlController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEBUqTrsVVLTbWYP&open=AaHOLEBUqTrsVVLTbWYP&pullRequest=412

Check warning on line 1227 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly specify the time zone by passing a ZoneId or a Clock to the .now() method. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYh&open=AaHOLEcjqTrsVVLTbWYh&pullRequest=412

Check warning on line 1086 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYf&open=AaHOLEcjqTrsVVLTbWYf&pullRequest=412

Check warning on line 50 in src/main/java/com/iemr/flw/controller/GeneralCheckUpFollowUpController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLD8TqTrsVVLTbWYK&open=AaHOLD8TqTrsVVLTbWYK&pullRequest=412

Check warning on line 927 in src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_FLW-API&issues=AaHOLEcjqTrsVVLTbWYY&open=AaHOLEcjqTrsVVLTbWYY&pullRequest=412
View more details on SonarQubeCloud