Repository navigation
4.6.7 - #1070
4.6.7#1070
Conversation
多字符运算符需要排在单字符字符类之前,否则 >=、<=、!= 会被拆开, 右侧变量名被拼接为 =xxx 而无法解析。
确认输入后先 unmountPerform,带 -continue 时会触发一次 goNextWhenOver, 随后又手动 continueSentence,导致推进两次。改为演出始终声明 goNextWhenOver,由卸载统一触发继续。
v2 动画的预览拖拽需要引擎在时刻 T 实际应用的 target 变换与本次使用的 基准状态:编辑器不能自行复刻 relative / inherit / relativeCalc 的合成。 seekAnimationPreview 已经算出这两份值,直接随命令响应返回。 响应仍是 preview.command.seek-animation 的 envelope,payload 增加 transform / baseTransform;旧客户端忽略未知字段,请求字段不变。
feat(webgal): 动画预览响应返回生效变换与基准状态
Fix user input continue
fix: 条件比较右侧使用裸变量时判断错误
…lative-animation feat: 支持静态组合立绘与相对动画
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying webgal-dev with
|
| Latest commit: |
257ae70
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae283586.webgal-dev.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e6036316c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const isSameSelection = existing.preset === next.preset && isEqual(existing.components, next.components); | ||
| const animName = isSameSelection ? null : createTransformAnimation(sentence, key, writeFullEffect, false); |
There was a problem hiding this comment.
Apply explicit transforms when the selection is unchanged
When a character already occupies the slot, repeating the same character and preset with a new -transform silently ignores the transform: isSameSelection prevents createTransformAnimation from being called, so neither the effects state nor the displayed character changes. The same transform works if the preset also changes, making transform handling depend on an unrelated selection change. Preserve the no-op optimization only when no explicit transform was supplied.
Useful? React with 👍 / 👎.
|
|
||
| const isSameSelection = existing.preset === next.preset && isEqual(existing.components, next.components); | ||
| const animName = isSameSelection ? null : createTransformAnimation(sentence, key, writeFullEffect, false); | ||
| if (!animName) return createNonePerform(); |
There was a problem hiding this comment.
Preserve continuation when switching presets without a transform
For a normal preset switch such as character:alice.smile -continue; on an existing Alice character, createTransformAnimation(..., false) returns null when no -transform is provided, and this branch returns createNonePerform(). PerformController.arrangeNewPerform discards that perform before startPerform can convert -continue into goNextWhenOver, so playback stops at the preset switch instead of continuing to the following dialogue. Return a named zero-duration perform, or otherwise preserve continuation for these instantaneous updates.
Useful? React with 👍 / 👎.
No description provided.