Repository navigation
feat(registry)!: registry to decide which datasets it accepts and rejects - #828
Merged
Merged
Conversation
RemoteRegistry no longer refuses a release because its access is not open. The service decides which releases a caller can read and which releases it accepts. - RemoteRegistry.requires_open_access is False. S3Registry keeps True, because a bucket has no service that checks access. - A 403 on the manifest route becomes TimeNetAccessError with the access level and page of the listed card. resolve() answers NotServed, so the lookup still falls through to the next source. - A 401 or 403 carries the whole reason that the service gives. A 401 also says how to set a token. BREAKING CHANGE: RemoteRegistry.requires_open_access changes from True to False. For a release that the service refuses, resolve() returns NotServed without a manifest, and TimeNet.get_manifest() raises TimeNetAccessError.
…release in dest A caller without the right to read a gated release got an access error with build hints when the destination already held the release. The copy now goes on to the publish request, so the service gives its own reason.
…nt none An anonymous 403 from the registry API now says how to set a token. A refusal of a token that the client sent, or of the object storage, no longer does.
…ess check No registry client refuses a release because of its access level any more. A registry service decides what it accepts and serves. For an s3:// registry, the owner of the bucket decides through the bucket permissions. A refusal of the service still becomes TimeNetAccessError and NotServed. A copy or a download takes a payload source that the service refuses from the destination, if the destination holds a complete copy. BREAKING CHANGE: BaseRegistry.requires_open_access, the open_access_only option of timenet.build() and plan_release_build(), require_open_access() and NotServed.manifest are gone. An S3Registry now holds and serves releases that are not open.
…resolve Drop the duplicate resolve overrides in RemoteRegistry and the test double, share one detail fetch helper, build the 401/403 message once, and remove the unused _GATED test constant.
…second lookup A 403 on a release read becomes TimeNetAccessError with the reason that the service gives, and resolve() answers NotServed. The client no longer fetches the latest card to guess the access level and page. That removes an extra request per refusal, the wrong page for an older version, and the raw 403 that escaped resolve() for a gated release with an open card. TimeNetAccessError and NotServed take an optional access level and a reason. BREAKING CHANGE: a refusal from a registry service no longer names the access level or the access page.
masquare
marked this pull request as ready for review
November 20, 2026 06:52
A writer token on the registry service can always read what it writes, so dest never refuses a read to a caller that may write. A caller without write access now gets the read refusal, which names TIMENET_TOKEN, instead of the write refusal.
karhu
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry that receives data now decides whether it accepts or serves a dataset. The TimeNet client no longer checks access levels. It always tries to publish and read, and the registry answers.
TIMENET_TOKEN.s3://registry, the bucket permissions decide.What changes in the client:
requires_open_access,require_open_access()and every client access check are removed.TimeNetAccessErrorwith the reason that the registry gives.resolve()returnsNotServed, so the lookup moves on to the next source.TimeNetRegistryErrorwith the reason that the registry gives.TIMENET_TOKENwhen the client sent no token.Breaking:
timenet.build(open_access_only=...)is removed.S3Registryholds and serves releases that are not open.Open point: the registry service checks only the card of the release, not its lineage. So it can accept a release with an open card and a non-open ancestor. If that matters, the service needs a lineage check.