Skip to content

feat(connectors): add EngineMT-QA with shared source validation and loading - #729

Closed
osbai wants to merge 1 commit into
feature/capture24-connector-v2from
feature/enginemt-qa-shared
Closed

osbai wants to merge 1 commit into
feature/capture24-connector-v2from
feature/enginemt-qa-shared

Conversation

@osbai

@osbai osbai commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Add EngineMT-QA with published question stages, label sets, split auditing, 33-channel signals and a repeatable task stream.

Use connector-local Pydantic validation, shared channel loading, numeric validation and round-trip assertions. Preserve conversation order, ID/name relationships and empty closed-answer semantics. Focused tests cover expected output, malformed sources, source changes and cache behavior; no full-release build was repeated.

Review the complete stack.

@osbai
osbai added this pull request to stack #728 November 6, 2026 20:02
@osbai
osbai force-pushed the feature/enginemt-qa-shared branch 5 times, most recently from ee69603 to 747cdfd Compare November 6, 2026 21:54
@osbai
osbai marked this pull request as ready for review November 6, 2026 22:08
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

⚠️ CI checks failed

Check Status
Quick checks ❌ Failed
Tests (Python 3.13) ⏭️ Did not run
Tests (Python 3.11) ⏭️ Did not run

Full output is in the job logs. Reproduce locally:

make lint-fix   # auto-fix
make check-ci   # the hooks, plus ty on 3.13 and 3.11
make test-unit  # the quick job's tests
make test       # the full suite

Updated for 378532a · run #8008

@osbai
osbai force-pushed the feature/enginemt-qa-shared branch from 747cdfd to af25fd0 Compare November 6, 2026 22:58
@osbai
osbai removed this pull request from stack #728 November 6, 2026 23:27
@osbai
osbai force-pushed the feature/enginemt-qa-shared branch from af25fd0 to ba3d1e6 Compare November 6, 2026 23:27
@osbai
osbai added this pull request to stack #738 November 6, 2026 23:28
…oading

Port the pandalin98/enginemt-qa snapshot from 0f448be without unrelated repository changes. Preserve the published question stages, label sets, split auditing, 33-channel signals and repeatable lazy task stream.

Use Pydantic SourceRow models, connector error conventions, the core bounded shared channel loader and numerical signal validation. Adopt assert_round_trips and verify lazy channel sharing and eviction with focused tests; 48 connector tests pass.
@osbai
osbai force-pushed the feature/enginemt-qa-shared branch from ba3d1e6 to 378532a Compare November 9, 2026 11:34
@karhu

karhu commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

PR spring cleaning
Closing as a duplicate of #629, which adds the same dataset and card as a single file. This copy builds on helpers that main replaced with #751 to #756.

@karhu karhu closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants