Repository navigation
Warn WHOOP users about firmware restrictions on data access - #680
Conversation
Reviewer's GuideUIAdd a shared advisory warning to the connection picker and WHOOP pairing screen, including retries, while allowing sensor-only flows to omit it.
DocumentationWarn WHOOP users about preserving open-source access and document firmware reports, evidence limits, and release timing.
TestsVerify warning placement and visibility, sensor-only omission, pairing retries, and usability with large text in both themes.
Other changesFiles not grouped.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="lib/ui2/pairing/whoop_firmware_warning.dart" line_range="58-59" />
<code_context>
+ l?.whoopFirmwareWarningDetails ??
+ 'Reports on WHOOP 5.0 / MG firmware 50.43.1.0 and 50.43.2.0 '
+ 'describe blocked data access. Bluetooth may still '
+ 'connect. OpenStrap cannot issue the WHOOP-signed '
+ 'membership token needed to unlock affected bands.',
+ style: F.cap.copyWith(color: p.ink2, height: 1.4),
+ ),
</code_context>
<issue_to_address>
**Users get unsupported diagnosis**
When a user on firmware 50.43.2.0 reads the pairing warning, the warning groups 50.43.2.0 with 50.43.1.0 and says a WHOOP-signed token is needed to unlock affected bands, so users see the token presented as the cause of the history-sync failure even though that cause is unestablished.
Distinguish the reports and state that the token-related cause for 50.43.2.0 is unestablished.
Also at `README.md:8-11`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: lib/ui2/pairing/whoop_firmware_warning.dart:59
| 'connect. OpenStrap cannot issue the WHOOP-signed ' | ||
| 'membership token needed to unlock affected bands.', |
There was a problem hiding this comment.
🟡 Medium · Users get unsupported diagnosis
When a user on firmware 50.43.2.0 reads the pairing warning, the warning groups 50.43.2.0 with 50.43.1.0 and says a WHOOP-signed token is needed to unlock affected bands, so users see the token presented as the cause of the history-sync failure even though that cause is unestablished.
Distinguish the reports and state that the token-related cause for 50.43.2.0 is unestablished.
Also at README.md:8-11.
Prompt for AI agents
In `lib/ui2/pairing/whoop_firmware_warning.dart` at lines 58-59:
**Users get unsupported diagnosis**
When a user on firmware 50.43.2.0 reads the pairing warning, the warning groups 50.43.2.0 with 50.43.1.0 and says a WHOOP-signed token is needed to unlock affected bands, so users see the token presented as the cause of the history-sync failure even though that cause is unestablished.
Distinguish the reports and state that the token-related cause for 50.43.2.0 is unestablished.
Also at `README.md:8-11`.
WHOOP users can lose access to band data after an automatic firmware update through the official app. Add a prominent warning at the top of the README, above search on the connection picker, and first on the WHOOP pairing screen, including retries. The warning advises both current users and people planning to switch to an open-source app later to avoid reconnecting to the official app and to uninstall or disable it. The app and README also state that we are working on a solution, but no fix is available yet.
Document the reported WHOOP-signed membership-token requirement on 50.43.1.0, the history-sync failure reported on 50.43.2.0, and certificate handling observed on MG 50.42.1.0. The README distinguishes these observations from confirmed enforcement and records availability of 50.43.1.0 by October 19, 2026. The exact rollout start and first enforcing version remain unknown. It does not claim the same restriction is established on WHOOP 4.0.
The warning is advisory and does not diagnose a band as locked from its firmware version. New strings are in the English localization template, with English fallback in other locales.
Related evidence: #673 and ryanbr/noop#2890. The README includes the source links and release-timing evidence. Wording approved by the requester before publication.
Validation:
Screenshot
Connection screen rendered from the production Flutter widgets at 390 × 844 logical pixels, with the bundled font and normal text size.
Summary by Sourcery
Warn WHOOP users about firmware updates that may restrict open-source access to band data.
New Features:
Enhancements:
Documentation:
Tests:
Chores: