Repository navigation
Conversation
`find -exec ... \;` always exits 0, so `make` reported success when the
mod's C# did not compile. `-exec ... {} +` returns the command's exit
status (and passes the solution explicitly instead of relying on the
working directory).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209.
find -exec ... \;always exits 0, somakereported success when the mod's C# did not compile.-exec ... {} +returns the command's exit status and passes the solution path explicitly. (With more than one root.sln,dotnet buildnow errors visibly; before, it also failed, but the failure was swallowed.)Testing: with a compile error in
OpenRA.Mods.Example,makeexits 0 before and 2 after; with valid code it still exits 0.These changes were written with the help of Claude Code. I reviewed the changes and tested them as described above, and I take responsibility for them.
🤖 Generated with Claude Code