Repository navigation
Conversation
atoi() has undefined behavior on out-of-range values. Parse the numeric suffix of form field names with strtol(), validate errno and the range, and return -1 on any invalid input instead. Fixes OpenPrinting#1748
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atoi()is used to parse the numeric suffix of CGI form field names into anarray index in
cgi-bin/var.c. On values that exceedINT_MAXthis isundefined behavior, and the result cannot be reliably validated by the
subsequent range check in
cgiSetArray().Add a
_cups_parse_index()helper that usesstrtol(), resets and checkserrnoforERANGE, and validates the parsed value before converting it toan index. Use it at the three sites that build array indices.
Changes
cgi-bin/var.c_cups_parse_index(); replace 3atoi(x)-1index computationsTest Plan
make(object compiles cleanly).non-numeric / negative / empty all return expected indices or -1.
Fixes #1748