Repository navigation
Stage a simulator's results without a glob per model - #381
Merged
Merged
Conversation
Publishing every branch after the first took 37 minutes for 103 libraries, while its slowest rsync took 4 seconds. stagePublished globbed <model>_<simulator>* once per model, and every glob reads all of files/, which by then holds the results of every library: the cost grew as models times files, serialised by the GIL across the publish threads. List files/ once per branch, sorted, and find each model's files by bisecting it. The per-library times printed after publishing now include the staging as well as the rsync. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing every branch after the first took 37 minutes for 103 libraries, while its slowest rsync took 4 seconds. stagePublished globbed _* once per model, and every glob reads all of files/, which by then holds the results of every library: the cost grew as models times files, serialised by the GIL across the publish threads.
List files/ once per branch, sorted, and find each model's files by bisecting it. The per-library times printed after publishing now include the staging as well as the rsync.
Assisted-by: Claude Opus 5.5