Repository navigation
add --ignoreUnitMismatch flag to allow connections for unit mismatches - #1683
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 28.35% 28.43% +0.08%
==========================================
Files 72 72
Lines 13976 13981 +5
Branches 9020 9023 +3
==========================================
+ Hits 3963 3976 +13
+ Misses 8775 8771 -4
+ Partials 1238 1234 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The new flag --ignoreUnitMismatch (default false) turns the error into a warning naming both connectors and their units, and connects them with
suppressUnitConversion=true, since the conversion factor between units of different dimensions is meaningless. Without the flag, the error now names the units and points to the flag.