Skip to content

OpenConceptLab/ocl_online#367 | Limit dialogs share one frame: Close first, then the next step - #119

Merged
snyaggarwal merged 1 commit into
mainfrom
ocl_online-367-preview-dialog-layout
Oct 29, 2026
Merged

snyaggarwal merged 1 commit into
mainfrom
ocl_online-367-preview-dialog-layout

Conversation

@paynejd

@paynejd paynejd commented Oct 28, 2026

Copy link
Copy Markdown
Member

Refs OpenConceptLab/ocl_online#367. Follows #116.

What changes

  • One frame for both limit dialogs. PreviewLimitDialog had its own layout. Now it and QuotaDialog both render through a new LimitDialog, which uses QuotaDialog's layout and the app's Dialog and DialogTitle. That layout is the title and close icon, what was refused, any message the connected service sends, then Close and the next-step button.
  • Close first, the next step second, with its new-tab icon. In PreviewLimitDialog the next-step button used to come first and had no icon.
  • "Close" everywhere. The dismiss button said "Back to my project", even on the project list where the New button opens this dialog. It now says Close, like QuotaDialog. The map_project.preview_limit_dismiss string is no longer used, so it leaves all four languages.
  • QuotaDialog is unchanged. Its before and after screenshots are byte-identical.
  • The close icon now has an accessible name in both dialogs.

Screenshots

These come from a throwaway component harness (not committed) with online-api stubbed. "Example action" and its message are placeholders for whatever the service sends.

Before After
before after
before, 375 px after, 375 px
before, es after, es
before, no next step after, no next step

QuotaDialog, unchanged:

QuotaDialog

The images live on the ocl_online-367-layout-screenshots branch, which holds only images and can be deleted after review.

Testing

  • I ran eslint src --ext .jsx,.js and npm run test:all as CI runs them: 607 unit and 11 integration tests pass.
  • I added no new test. Neither test runner can load JSX, and this change is layout only, so the screenshots above cover it.

cc @snyaggarwal (for reading; no approval needed)

🤖 Generated with Claude Code

https://claude.ai/code/session_01AaZ4qVXboeBSRvAQgQjdbs

…first, then the next step

PreviewLimitDialog had its own layout: the next-step button came first, had
no new-tab icon, and the dismiss button said "Back to my project" even on the
project list. Both limit dialogs now render through LimitDialog, which is
QuotaDialog's layout: the title and close icon, what was refused, any message
the connected service sends, then Close and the next-step button with its
new-tab icon. QuotaDialog renders exactly as before.

The dismiss string is no longer used, so it leaves all four languages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AaZ4qVXboeBSRvAQgQjdbs
@paynejd

paynejd commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

Codex review, pass 1 (codex-cli 0.165.0, commit 0834474)

Verdict: clean. No findings.

findings.json
{
  "reviewer": "codex-cli 0.165.0",
  "perspective": "defects",
  "mode": "full",
  "commit": "0834474",
  "verdict": "clean",
  "prior": [],
  "findings": []
}

@paynejd

paynejd commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

Simplification review (fresh Claude subagent, commit 0834474)

Verdict: clean. Nothing to cut. No commits came after the reviewed one, so no further Codex check is needed.

findings.json
{
  "reviewer": "claude subagent",
  "perspective": "simplify",
  "mode": "full",
  "commit": "0834474",
  "verdict": "clean",
  "prior": [],
  "findings": []
}

@snyaggarwal
snyaggarwal merged commit aa00459 into main Oct 29, 2026
2 checks passed
@snyaggarwal
snyaggarwal deleted the ocl_online-367-preview-dialog-layout branch October 29, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants