Repository navigation
OpenConceptLab/ocl_online#367 | Limit dialogs share one frame: Close first, then the next step - #119
Merged
Conversation
…first, then the next step PreviewLimitDialog had its own layout: the next-step button came first, had no new-tab icon, and the dismiss button said "Back to my project" even on the project list. Both limit dialogs now render through LimitDialog, which is QuotaDialog's layout: the title and close icon, what was refused, any message the connected service sends, then Close and the next-step button with its new-tab icon. QuotaDialog renders exactly as before. The dismiss string is no longer used, so it leaves all four languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaZ4qVXboeBSRvAQgQjdbs
Member
Author
Codex review, pass 1 (codex-cli 0.165.0, commit 0834474)Verdict: clean. No findings. findings.json{
"reviewer": "codex-cli 0.165.0",
"perspective": "defects",
"mode": "full",
"commit": "0834474",
"verdict": "clean",
"prior": [],
"findings": []
} |
Member
Author
Simplification review (fresh Claude subagent, commit 0834474)Verdict: clean. Nothing to cut. No commits came after the reviewed one, so no further Codex check is needed. findings.json{
"reviewer": "claude subagent",
"perspective": "simplify",
"mode": "full",
"commit": "0834474",
"verdict": "clean",
"prior": [],
"findings": []
} |
snyaggarwal
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs OpenConceptLab/ocl_online#367. Follows #116.
What changes
PreviewLimitDialoghad its own layout. Now it andQuotaDialogboth render through a newLimitDialog, which usesQuotaDialog's layout and the app'sDialogandDialogTitle. That layout is the title and close icon, what was refused, any message the connected service sends, then Close and the next-step button.PreviewLimitDialogthe next-step button used to come first and had no icon.QuotaDialog. Themap_project.preview_limit_dismissstring is no longer used, so it leaves all four languages.QuotaDialogis unchanged. Its before and after screenshots are byte-identical.Screenshots
These come from a throwaway component harness (not committed) with online-api stubbed. "Example action" and its message are placeholders for whatever the service sends.
QuotaDialog, unchanged:The images live on the
ocl_online-367-layout-screenshotsbranch, which holds only images and can be deleted after review.Testing
eslint src --ext .jsx,.jsandnpm run test:allas CI runs them: 607 unit and 11 integration tests pass.cc @snyaggarwal (for reading; no approval needed)
🤖 Generated with Claude Code
https://claude.ai/code/session_01AaZ4qVXboeBSRvAQgQjdbs