This repository was archived by the owner on Oct 17, 2026. It is now read-only.
Repository navigation
feat(execute): optional Cloud issuer seal_signature on ExecuteEvidenceReceiptV1 - #44
Merged
Merged
Conversation
…eReceiptV1 Adds openadapt_types.seal: SealSignatureV1 (openadapt.seal-signature/v1), key registry parsing, and fail-closed verify_seal_signature / verify_sealed_receipt, byte-compatible with Cloud's sealSignature.ts (a TypeScript-generated test vector verifies in Python). The receipt gains an optional seal_signature; existing receipts stay valid and are unsigned. Verification needs cryptography and refuses without it. Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
Member
Author
|
Self-review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security-sensitive (Seal verification contract): left for Richard's review.
openadapt_types/seal.py:SealSignatureV1(openadapt.seal-signature/v1, Ed25519, issueropenadapt-cloud).parse_key_registry(active/revoked keys).verify_seal_signatureandverify_sealed_receipt, which refuse with a closed reason:unsigned,malformed,receipt_mismatch,unknown_key,revoked_key,bad_signature, orverifier_unavailable.ExecuteEvidenceReceiptV1.seal_signature: SealSignatureV1 | None = None. The field is optional and additive. Existing receipts still validate and count as unsigned. The OpenAPI doc is regenerated.seal_signature.src/lib/sealSignature.ts(OpenAdaptAI/openadapt-cloud#399).tests/fixtures/cloud-seal-signature-vector.jsonwas generated by the TS signer with a fixed test seed and verifies in Python.cryptographyis not added as a dependency, so the lock is unchanged. Verification refuses without it. CI runstests/test_seal.pywith--with cryptography.Tests: 5 new, 671 total passing locally.