Repository navigation
ci(desktop): a dispatched release waits on a first-parent commit - #1398
Merged
Merged
Conversation
The release gate waits for the Packages push run of the newest commit that changed Desktop. On a dispatch it chose that commit from full history, which can be a commit inside a merged branch; such a commit never gets a Packages push run on main, so the 0.21.1 release waited 60 minutes for c95e6f0 and refused. Follow main's first-parent history instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.21.1 Desktop release (run 39353112022) refused after 60 minutes. On a dispatch, the gate picks the newest commit that changed
packages/desktopand waits for its Packages push run. It picked c95e6f0, a commit inside the merged #1382 branch. A commit inside a merged branch never gets a Packages push run on main, so the gate polled0 missing pendinguntil it timed out.Fix: choose the subject from main's first-parent history (
git log -1 --first-parent). Those commits are the ones pushed to main, so each has a Packages push run. The next step still requires that main hasn't changed Desktop since that commit, and that the tip's tree matches it.Test:
tests/test_desktop_release_subject.pyfails without the fix and passes with it.🤖 Generated with Claude Code